[PATCH] Add missing pthread_condattr_{init,destroy} stubs to libc

[Joe Marcus Clarke]

On Sat, 2009-11-28 at 00:30 +0200, Kostik Belousov wrote:
> On Fri, Nov 27, 2009 at 05:28:07PM -0500, Joe Marcus Clarke wrote:
> > On Sat, 2009-11-28 at 00:22 +0200, Kostik Belousov wrote:
> > > On Fri, Nov 27, 2009 at 05:11:13PM -0500, Joe Marcus Clarke wrote:
> > > > I didn't see a better way of fixing this.  I'm still fuzzy on how to do
> > > > the correct symbol map dance for libthr/libc_r.  Do you know of any
> > > > example symbols which had to be updated in this fashion?
> > > 
> > > pthread_condattr_init and _destroy are exported from libthr in FBSD_1.0.
> > > namespace. I think stubs should go into FBSD_1.0 namespace in libc then.
> > > 
> > > We nullified one of the use for symver by extending existing
> > > namespaces (symbol versioning, as defined by Sun, allowed for dynamic
> > > linker to make a guarantee that process does not have unresolved
> > > symbols only by checking that all required versions are provided
> > > by libraries). My opinion that adding them to FBSD_1.0 is ok.
> > 
> > That's easy enough.  New patch is up.
> > 
> > http://www.marcuscom.com/downloads/stubs.diff
> 
> I think symbols should be added in the pthread_* block of the
> libc/gen/Symbol.map, arranged alphabetically.

Wasn't sure of that.  I had it that way originally, then I thought maybe
they were being organized in order of inclusion (as I saw some others
out of alphabetical order).  I can easily shuffle them around.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-threads/attachments/20091127/72d6cbf4/attachment.pgp