[Bug 252096] fusefs tests depend on maxphys
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Mon Dec 28 18:58:10 UTC 2020
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252096
--- Comment #1 from commit-hook at FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=f928dbcb167c7440212e420687de813fc92c06a4
commit f928dbcb167c7440212e420687de813fc92c06a4
Author: Alan Somers <asomers at FreeBSD.org>
AuthorDate: 2020-12-24 06:03:06 +0000
Commit: Alan Somers <asomers at FreeBSD.org>
CommitDate: 2020-12-28 18:56:17 +0000
fusefs: fix the tests for a wider range of maxphys
maxphys is now a tunable, ever since r368124. The default value is also
larger than it used to be. That broke several fusefs tests that made
assumptions about maxphys.
* WriteCluster.clustering used the MAXPHYS compile-time constant.
* WriteBackAsync.direct_io_partially_overlaps_cached_block implicitly
depended on the default value of maxphys. Fix it by making the
dependency explicit.
* Write.write_large implicitly assumed that maxphys would be no more
than twice maxbcachebuf. Fix it by explicitly setting m_max_write.
* WriteCluster.clustering and several others failed because the MockFS
module did not work for max_write > 128KB (which most tests would set
when maxphys > 256KB). Limit max_write accordingly. This is the same
as fusefs-libs's behavior.
* Bmap's tests were originally written for MAXPHYS=128KB. With larger
values, the simulated file size was too small.
PR: 252096
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D27769
tests/sys/fs/fusefs/bmap.cc | 12 ++++++++----
tests/sys/fs/fusefs/mockfs.cc | 2 +-
tests/sys/fs/fusefs/mockfs.hh | 21 +++++++++++++++++++--
tests/sys/fs/fusefs/utils.cc | 13 ++++++-------
tests/sys/fs/fusefs/utils.hh | 3 +--
tests/sys/fs/fusefs/write.cc | 18 +++++++++++++++++-
6 files changed, 52 insertions(+), 17 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-testing
mailing list