[PATCH] Install recently added tests

Ngie Cooper yaneurabeya at gmail.com
Fri Sep 29 20:28:04 UTC 2017


> On Sep 29, 2017, at 12:56, Vladimir Zakharov <zakharov.vv at gmail.com> wrote:
> 
> Hello!
> 
> r323275 added basic tests for chflags, mkdir, rcp and rmdir. But these
> tests are not installed to /usr/tests.

LGTM.

This is the bad downside of the SUBDIR.yes pattern that's bitten me in the ass a couple times now.

> # kyua test -k /usr/tests/Kyuafile bin/chflags
> Results file id is usr_tests.20170929-195409-880951
> Results saved to /root/.kyua/store/results.usr_tests.20170929-195409-880951.db
> kyua: W: No test cases matched by the filter 'bin/chflags'.
> # ls /usr/tests/bin/chflags/
> #
> 
> Attached patch fixes this problem.
> 
> Index: bin/chflags/Makefile
> ===================================================================
> --- bin/chflags/Makefile    (revision 324095)
> +++ bin/chflags/Makefile    (working copy)
> @@ -1,6 +1,8 @@
> #    @(#)Makefile    8.1 (Berkeley) 6/6/93
> # $FreeBSD$
> 
> +.include <src.opts.mk>
> +
> PACKAGE=runtime
> PROG=    chflags
> 
> Index: bin/mkdir/Makefile
> ===================================================================
> --- bin/mkdir/Makefile    (revision 324095)
> +++ bin/mkdir/Makefile    (working copy)
> @@ -1,6 +1,8 @@
> #    @(#)Makefile    8.1 (Berkeley) 5/31/93
> # $FreeBSD$
> 
> +.include <src.opts.mk>
> +
> PACKAGE=runtime
> PROG=    mkdir
> 
> Index: bin/rcp/Makefile
> ===================================================================
> --- bin/rcp/Makefile    (revision 324095)
> +++ bin/rcp/Makefile    (working copy)
> @@ -1,6 +1,8 @@
> #    @(#)Makefile    8.1 (Berkeley) 7/19/93
> # $FreeBSD$
> 
> +.include <src.opts.mk>
> +
> PACKAGE=rcmds
> PROG=    rcp
> SRCS=    rcp.c util.c
> Index: bin/rmdir/Makefile
> ===================================================================
> --- bin/rmdir/Makefile    (revision 324095)
> +++ bin/rmdir/Makefile    (working copy)
> @@ -1,6 +1,8 @@
> #    @(#)Makefile    8.1 (Berkeley) 5/31/93
> # $FreeBSD$
> 
> +.include <src.opts.mk>
> +
> PACKAGE=runtime
> PROG=    rmdir
> 
> -- 
> Regards,                 | "In theory there is no difference between theory
>  Vladimir Zakharov      | and practice. In practice there is."- Yogi Berra
> _______________________________________________
> freebsd-testing at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-testing
> To unsubscribe, send any mail to "freebsd-testing-unsubscribe at freebsd.org"


More information about the freebsd-testing mailing list