[RFC] Rename `make test` in suite.test.mk with `make regress`

Julio Merino jmmv at freebsd.org
Sun Oct 18 01:50:11 UTC 2015


On Oct 17, 2015, at 18:03, NGie Cooper <yaneurabeya at gmail.com> wrote:
> 
> Hi all,
> 	There’s a lesser known target in suite.test.mk that runs `kyua test` in a similar manner to how Jenkins and other groups have integrated kyua into their test infrastructures.
> 	The legacy target on FreeBSD was `regress`, but the target created with the bsd.test.mk creation back a few years ago was `test`. Why change from `test` to `regress`? There are places in the tree (bin/test for example) that have targets named test, so in order to avoid clashing with a common target (name), it’s best to use the legacy target name.
> 	Would anyone have any serious heartburn over the change?

Is this only because of bin/test?  Seems like renaming a target to avoid that one collision is just moving the problem around.  It is possible that some other directory could later grow a target that conflicts with your new name.

Strictly speaking, "regress" is wrong.  We do not have regression tests only.  Also, "regress" is a pretty obscure name for a target; it does not appear in any other projects nor in any other build systems that I know of.

Have you considered "check"?  That'd be in line with what automake does, for example, which would homogenize the target name with a ton of other projects out there.


More information about the freebsd-testing mailing list