Requests for Help: add FreeBSD procstat support to akuma library for Jenkins
Michael Zhilin
mizhka at gmail.com
Mon Jun 29 21:46:31 UTC 2015
Hi,
Here is possible fix (at least works for me @FBSD10-stable):
https://github.com/kohsuke/akuma/pull/9
Could you please test it with Jenkins auto-restart?
Thank you,
Michael!
On Mon, Jun 29, 2015 at 7:35 PM, Jung-uk Kim <jkim at freebsd.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 06/28/2015 17:15, Craig Rodrigues wrote:
>> On Thu, Jun 25, 2015 at 4:21 PM, Jung-uk Kim <jkim at freebsd.org>
>> wrote:
>>
>> You can try the attached trivial patch. Note it requires
>> procfs(5).
>>
>>
>> Thanks for submitting that patch. I thought about something like
>> that before.
>>
>> I am hesitant about pushing this patch upstream, because it would
>> make akuma + Jenkins dependent on procfs. This dependency would be
>> new, since FreeBSD procfs is not mandatory and only available as
>> an option.
>>
>> Since procstat has been available in the base system since FreeBSD
>> 7.1, I recommended using that in the akuma library, even though it
>> is a little bit more work to implement.
>
> Although I agree that using procfs is not ideal, we already use procfs
> for Java implementations.
>
> https://svnweb.freebsd.org/ports/head/java/openjdk6/pkg-message?revision=340719&view=co
> https://svnweb.freebsd.org/ports/head/java/openjdk7/pkg-message?revision=357236&view=co
> https://svnweb.freebsd.org/ports/head/java/openjdk8/pkg-message?revision=349468&view=co
>
> I don't see any reason to prefer procstat.
>
> Jung-uk Kim
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQEcBAEBCAAGBQJVkXPnAAoJEHyflib82/FG/7YH/jkfoWyOQ3e/8kGcP0GhUK3q
> EBBHzvvgOy/KiCnVsRdDNsTKo6RoI2jh9z+zPsf/AoPCi9mFalLWhQM5TSIVzBbM
> 8nmOKtIj58fCkquBVRsWC2cDDlCB+A04O0/rukLYDDxLIL5dDxTdD0ZgWJ5/JsT7
> zZQ6qoLtGwF7FvmHQ8u8LQ70HZHjBbZ9I7QgmbwqtkSF1pXBf/mKyucKBoKmxPlc
> /V2IdNKbpxGVclFwfg2SYR73Cbo6au7GEIKDJ4ud0lpo7hmQlefA87qg3P+n8/yI
> ZUUGSoNzNrB4rxdjT8DY9fSEqYu+JYdt67dsbZd5laKQn9ZiKpd/L/uZvrJCxXo=
> =RMCF
> -----END PGP SIGNATURE-----
> _______________________________________________
> freebsd-java at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-java
> To unsubscribe, send any mail to
> "freebsd-java-unsubscribe at freebsd.org"
More information about the freebsd-testing
mailing list