ATF work

Peter Holm peter at holm.cc
Wed Apr 2 17:54:37 UTC 2014


On Wed, Apr 02, 2014 at 10:21:26AM -0700, Craig Rodrigues wrote:
> On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers <asomers at freebsd.org> wrote:
> > On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm <peter at holm.cc> wrote:
> >> I have uploaded a snapshot of the ATF work done for EMC Isilon,
> >> based primarily on Garrett Cooper's work.
> >>
> >> http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz
> >> +
> >> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr
> >
> > Holy patch queue, Batman!  There's fifty thousand lines of code in here!
> 
> 
> When a patch is that big, it becomes very difficult to review.
> 
> You might want to consider forking a copy on github of the
> https://github.com/freebsd/freebsd repository and maintaining the patch there
> until it is MFC'd:
> 
> https://help.github.com/articles/fork-a-repo
> https://help.github.com/articles/syncing-a-fork
> 
> It's not perfect but some of the web interface tools around the github
> ecosystem make reviewing patches (and contributing updates) a bit easier.
> 

Thank you for the references. I will definitely look at this.
-- 
Peter


More information about the freebsd-testing mailing list