[Bug 202058] bsdinstall - Disable dialog(3) for distfetch/checksum/distextract targets

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202058

--- Comment #11 from Ganael LAPLANCHE <ganael.laplanche at corp.ovh.com> ---
Hi Devin,

Thanks for your answer. You're definitely right, tty availability should be
detected at runtime.

I have focused on C tools (i.e. distfetch and distextract). Find attached two
patches -one for each tool- implementing what has been written so far.

A few things may still be addressed:

- libdpv(3) is not built at all if dialog(3) is not built, anyway it can be
used with DPV_DISPLAY_STDOUT which does not need dialog(3). Maybe HAVE_DIALOG
stuff can be added there too to enable building libdpv(3) without dialog(3) ?
- output of distextract is not really sexy when using DPV_DISPLAY_STDOUT
(anyway, "it works (TM)")
- other code from bsdinstall still needs work : partedit (does that make sense
?) and scripts/ directory
- we may still want to add nonInteractive stuff, because a few calls to
dialog_msgbox(,,,,TRUE) remain interactive, just waiting for the user to
acknowledge the msg box
- finally, I have not added any option to the tools and rely on the 'noTty' env
variable only (to keep the original spirit of the tools)

Best regards,
Ganael.

-- 
You are receiving this mail because:
You are the assignee for the bug.