cpioVerbose=medium broken because cpio(1) no longer accepts
-V/--dot
Randi Harper
randi at freebsd.org
Wed Oct 27 18:42:37 UTC 2010
I have no problem with this patch. Anyone else care to comment?
-- randi
On Wed, Oct 27, 2010 at 9:56 AM, Devin Teske <dteske at vicor.com> wrote:
> Some screenshots of the problem...
>
> 1. Set cpioVerbose=medium in the Options editor:
>
> http://druidbsd.sf.net/images/cpioVerbose_medium_option.png
>
> 2. Try to perform installation, but error out when unpacking the first
> distribution-set (base):
>
> http://druidbsd.sf.net/images/cpioVerbose_medium_ttyv0_error1.png
>
> 3. Second error message following the first:
>
> http://druidbsd.sf.net/images/cpioVerbose_medium_ttyv0_error2.png
>
> 4. Meanwhile, over on the debug console:
>
> http://druidbsd.sf.net/images/cpioVerbose_medium_ttyv1_error.png
>
>
> And finally, in tracking down the problem, it appears that FreeBSD-4.x
> used gnu-cpio while I see that FreeBSD-8.x is using bsd-cpio. This
> explains why `-V'/`--dot' flags have gone missing.
>
> Writing a PR for this [sysinstall] bug.
> --
> Devin
>
>
>
> On Tue, 2010-10-26 at 22:03 -0700, Devin Teske wrote:
>> Hello fellow sysinstall-hackers,
>>
>>
>> I've been working on some new additions to sysinstall and in
>> performing some tests, I came across a rather odd situation.
>>
>>
>> I threw "cpioVerbose=medium" into our install.cfg file for sysinstall
>> (8) and it barfed up an error while trying to unpack the split
>> tarballs (blah blah "cpio exited with error status: 1").
>>
>>
>> Upon closer investigation, it appears that cpio(1) no longer supports
>> the "-V" flag which used to print a single "." for each file
>> processed.
>>
>>
>> This is rather unfortunate because it now means that we're limited to
>> passing "-v" for full verbosity or no "-v" for no output, nothing in-
>> between like "-V" or "--dot" from the old FreeBSD-4.11 cpio.
>>
>>
>> Although I'd rather see cpio(1) patched to once-again support a
>> medium-verbosity option, I think maybe it's come to the point where we
>> take this out of sysinstall.
>>
>>
>> Here's the unified patch of the three files that need patching to
>> deprecate the use of `-V' in sysinstall(8) (comments welcome):
>>
>>
>> --- usr.sbin/sysinstall/help/shortcuts.hlp.orig 2007-06-25
>> 09:37:17.000000000 -0700
>> +++ usr.sbin/sysinstall/help/shortcuts.hlp 2010-10-26
>> 15:37:45.000000000 -0700
>> @@ -13,7 +13,7 @@ blanktime Screen blank tim
>> bootManager Select boot manager: booteasy, standard or
>> none
>> browserBinary Which doc browser to use (default: links)
>> browserPackage Which package to get browser from (default:
>> links)
>> -cpioVerbose How verbose to be with cpio: high, medium or
>> low
>> +cpioVerbose How verbose to be with cpio: high or low
>> debug Extra debugging?
>> defaultrouter IP address of default route
>> disk Which disk to operate on (ad0, da0, etc).
>> --- usr.sbin/sysinstall/media.c.orig 2010-06-13 19:09:06.000000000
>> -0700
>> +++ usr.sbin/sysinstall/media.c 2010-10-26 15:51:06.000000000 -0700
>> @@ -117,8 +117,6 @@ cpioVerbosity()
>>
>> if (cp && !strcmp(cp, "high"))
>> return "-v";
>> - else if (cp && !strcmp(cp, "medium"))
>> - return "-V";
>> return "";
>> }
>>
>> @@ -848,8 +846,6 @@ mediaSetCPIOVerbosity(dialogMenuItem *se
>> }
>> else {
>> if (!strcmp(cp, "low"))
>> - variable_set2(VAR_CPIO_VERBOSITY, "medium", 0);
>> - else if (!strcmp(cp, "medium"))
>> variable_set2(VAR_CPIO_VERBOSITY, "high", 0);
>> else /* must be "high" - wrap around */
>> variable_set2(VAR_CPIO_VERBOSITY, "low", 0);
>> --- usr.sbin/sysinstall/sysinstall.8.orig 2010-06-13
>> 19:09:06.000000000 -0700
>> +++ usr.sbin/sysinstall/sysinstall.8 2010-10-26 15:57:21.000000000
>> -0700
>> @@ -749,8 +749,7 @@
>> .Sy Variables :
>> .Bl -tag -width indent
>> .It cpioVerbose
>> -Can be used to set the verbosity of cpio extractions to low, medium
>> or
>> -high.
>> +Can be used to set the verbosity of cpio extractions to low or high.
>> .El
>> .It mediaGetType
>> Interactively get the user to specify some type of media.
>>
>>
>> P.S. It should be noted that cpioVerbose=high and cpioVerbose=low both
>> work as expected.
>> --
>> Cheers,
>> Devin Teske
>>
>>
>> -> CONTACT INFORMATION <-
>> Business Solutions Consultant II
>> FIS - fisglobal.com
>> 510-735-5650 Mobile
>> 510-621-2038 Office
>> 510-621-2020 Office Fax
>> 909-477-4578 Home/Fax
>> devin.teske at fisglobal.com
>>
>> -> LEGAL DISCLAIMER <-
>> This message contains confidential and proprietary information
>> of the sender, and is intended only for the person(s) to whom it
>> is addressed. Any use, distribution, copying or disclosure by any
>> other person is strictly prohibited. If you have received this
>> message in error, please notify the e-mail sender immediately,
>> and delete the original message without making a copy.
>>
>> -> FUN STUFF <-
>> -----BEGIN GEEK CODE BLOCK-----
>> Version 3.1
>> GAT/CS d(+) s: a- C++(++++) UB++++$ P++(++++) L++(++++) !E--- W++ N?
>> o? K- w O
>> M+ V- PS+ PE Y+ PGP- t(+) 5? X+(++) R>++ tv(+) b+(++) DI+(++) D(+) G
>> +>++ e>+ h
>> r>++ y+
>> ------END GEEK CODE BLOCK------
>> http://www.geekcode.com/
>>
>> -> END TRANSMISSION <-
>
> --
> Cheers,
> Devin Teske
>
> -> CONTACT INFORMATION <-
> Business Solutions Consultant II
> FIS - fisglobal.com
> 510-735-5650 Mobile
> 510-621-2038 Office
> 510-621-2020 Office Fax
> 909-477-4578 Home/Fax
> devin.teske at fisglobal.com
>
> -> LEGAL DISCLAIMER <-
> This message contains confidential and proprietary information
> of the sender, and is intended only for the person(s) to whom it
> is addressed. Any use, distribution, copying or disclosure by any
> other person is strictly prohibited. If you have received this
> message in error, please notify the e-mail sender immediately,
> and delete the original message without making a copy.
>
> -> FUN STUFF <-
> -----BEGIN GEEK CODE BLOCK-----
> Version 3.1
> GAT/CS d(+) s: a- C++(++++) UB++++$ P++(++++) L++(++++) !E--- W++ N? o? K- w O
> M+ V- PS+ PE Y+ PGP- t(+) 5? X+(++) R>++ tv(+) b+(++) DI+(++) D(+) G+>++ e>+ h
> r>++ y+
> ------END GEEK CODE BLOCK------
> http://www.geekcode.com/
>
> -> END TRANSMISSION <-
>
> _______________________________________________
> freebsd-sysinstall at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall
> To unsubscribe, send any mail to "freebsd-sysinstall-unsubscribe at freebsd.org"
>
More information about the freebsd-sysinstall
mailing list