standards/172805: Fix catopen(3)' s EINVAL usage and document EFTYPE

[Zhihao Yuan]

The following reply was made to PR standards/172805; it has been noted by GNATS.

From: Zhihao Yuan <lichray at gmail.com>
To: bug-followup at FreeBSD.org, lichray at gmail.com
Cc:  
Subject: Re: standards/172805: Fix catopen(3)'s EINVAL usage and document EFTYPE
Date: Wed, 17 Oct 2012 03:42:41 -0500

 --f46d04339c4cf73c4604cc3d4023
 Content-Type: text/plain; charset=UTF-8
 
 Further points out more EFTYPE errors.
 
 The exact explanation of EFTYPE here should be "The file designated by
 the named catalog is not a regular file or a symbolic link pointing to
 a regular file, or its data format is not POSIX NLS catalog.", which
 confirms with the general meaning of EFTYPE "Inappropriate file type
 or format.  The file was the wrong type for the operation, or a data
 file had the wrong format.". Please help improve the wording in
 catopen.3 is you find that the current version is not enough.
 
 -- 
 Zhihao Yuan, nickname lichray
 The best way to predict the future is to invent it.
 ___________________________________________________
 4BSD -- http://4bsd.biz/
 
 --f46d04339c4cf73c4604cc3d4023
 Content-Type: application/octet-stream; name="catopen3_1.patch"
 Content-Disposition: attachment; filename="catopen3_1.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_h8e6ihf80
 
 ZGlmZiAtLWdpdCBsaWIvbGliYy9ubHMvY2F0b3Blbi4zIGxpYi9saWJjL25scy9jYXRvcGVuLjMK
 aW5kZXggN2ExNmVlNS4uM2RlMjY1NSAxMDA2NDQKLS0tIGxpYi9saWJjL25scy9jYXRvcGVuLjMK
 KysrIGxpYi9saWJjL25scy9jYXRvcGVuLjMKQEAgLTI3LDcgKzI3LDcgQEAKIC5cIiBUSElTIFNP
 RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF
 LgogLlwiCiAuXCIgJEZyZWVCU0QkCi0uRGQgRmVicnVhcnkgMTIsIDIwMDUKKy5EZCBPY3RvYmVy
 IDE3LCAyMDEyCiAuRHQgQ0FUT1BFTiAzCiAuT3MKIC5TaCBOQU1FCkBAIC0xMzIsMTAgKzEzMiwx
 MyBAQCBPdGhlcndpc2UsIChubF9jYXRkKSAtMSBpcyByZXR1cm5lZCBhbmQKIGlzIHNldCB0byBp
 bmRpY2F0ZSB0aGUgZXJyb3IuCiAuU2ggRVJST1JTCiAuQmwgLXRhZyAtd2lkdGggRXIKKy5JdCBC
 cSBFciBFRlRZUEUKK1RoZSB0YXJnZXQgZmlsZSBpcyBub3QgYSBmb3JtYXR0ZWQgbWVzc2FnZSBj
 YXRhbG9nIGZpbGUuCiAuSXQgQnEgRXIgRUlOVkFMCiBBcmd1bWVudAogLkZhIG5hbWUKLWRvZXMg
 bm90IHBvaW50IHRvIGEgdmFsaWQgbWVzc2FnZSBjYXRhbG9nLCBvciBjYXRhbG9nIGlzIGNvcnJ1
 cHQuCitwb2ludHMgdG8KKy5EdiBOVUxMIC4KIC5JdCBCcSBFciBFTkFNRVRPT0xPTkcKIEFuIGVu
 dGlyZSBwYXRoIHRvIHRoZSBtZXNzYWdlIGNhdGFsb2cgZXhjZWVkZWQgMTAyNCBjaGFyYWN0ZXJz
 LgogLkl0IEJxIEVyIEVOT0VOVApAQCAtMTU0LDQgKzE1Nyw0IEBAIEluc3VmZmljaWVudCBtZW1v
 cnkgaXMgYXZhaWxhYmxlLgogVGhlCiAuRm4gY2F0b3BlbgogZnVuY3Rpb24gY29uZm9ybXMgdG8K
 LS5TdCAtcDEwMDMuMS0yMDAxIC4KKy5TdCAtcDEwMDMuMS0yMDA4IC4KZGlmZiAtLWdpdCBsaWIv
 bGliYy9ubHMvbXNnY2F0LmMgbGliL2xpYmMvbmxzL21zZ2NhdC5jCmluZGV4IDQ0YjE0NDAuLjRh
 NjI0MzEgMTAwNjQ0Ci0tLSBsaWIvbGliYy9ubHMvbXNnY2F0LmMKKysrIGxpYi9saWJjL25scy9t
 c2djYXQuYwpAQCAtMTE5LDggKzExOSwxMCBAQCBjYXRvcGVuKGNvbnN0IGNoYXIgKm5hbWUsIGlu
 dCB0eXBlKQogCWNoYXIgcGF0aFtQQVRIX01BWF07CiAKIAkvKiBzYW5pdHkgY2hlY2tpbmcgKi8K
 LQlpZiAobmFtZSA9PSBOVUxMIHx8ICpuYW1lID09ICdcMCcpCisJaWYgKG5hbWUgPT0gTlVMTCkK
 IAkJTkxSRVRFUlIoRUlOVkFMKTsKKwlpZiAoKm5hbWUgPT0gJ1wwJykKKwkJTkxSRVRFUlIoRU5P
 RU5UKTsKIAogCWlmIChzdHJjaHIobmFtZSwgJy8nKSAhPSBOVUxMKQogCQkvKiBoYXZlIGEgcGF0
 aG5hbWUgKi8KQEAgLTM2Nyw2ICszNjksNyBAQCBsb2FkX21zZ2NhdChjb25zdCBjaGFyICpwYXRo
 LCBjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICpsYW5nKQogCXN0cnVjdCBjYXRlbnRyeSAq
 bnA7CiAJdm9pZCAqZGF0YTsKIAlpbnQgZmQ7CisJaW50IHNhdmVkX2Vycm5vOwogCiAJLyogcGF0
 aC9uYW1lIHdpbGwgbmV2ZXIgYmUgTlVMTCBoZXJlICovCiAKQEAgLTM5MCw2ICszOTMsMTQgQEAg
 bG9hZF9tc2djYXQoY29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hh
 ciAqbGFuZykKIAl9CiAKIAlpZiAoX2ZzdGF0KGZkLCAmc3QpICE9IDApIHsKKwkJc2F2ZWRfZXJy
 bm8gPSBlcnJubzsKKwkJX2Nsb3NlKGZkKTsKKwkJU0FWRUZBSUwobmFtZSwgbGFuZywgc2F2ZWRf
 ZXJybm8pOworCQlOTFJFVEVSUihzYXZlZF9lcnJubyk7CisJfQorCisJLyogVGhlIGZpbGUgaXMg
 dG9vIHNtYWxsIHRvIGNvbnRhaW4gYSBfTkxTX01BR0lDLiAqLworCWlmIChzdC5zdF9zaXplIDwg
 c2l6ZW9mKHVfaW50MzJfdCkpIHsKIAkJX2Nsb3NlKGZkKTsKIAkJU0FWRUZBSUwobmFtZSwgbGFu
 ZywgRUZUWVBFKTsKIAkJTkxSRVRFUlIoRUZUWVBFKTsKQEAgLTQwOCw3ICs0MTksMTUgQEAgbG9h
 ZF9tc2djYXQoY29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAq
 bGFuZykKIAogCWlmICgoZGF0YSA9IG1tYXAoMCwgKHNpemVfdClzdC5zdF9zaXplLCBQUk9UX1JF
 QUQsCiAJICAgIE1BUF9GSUxFfE1BUF9TSEFSRUQsIGZkLCAob2ZmX3QpMCkpID09IE1BUF9GQUlM
 RUQpIHsKLQkJaW50IHNhdmVkX2Vycm5vID0gZXJybm87CisJCS8qCisJCSAqIG1tYXAoMikgc2V0
 cyBFSU5WQUwgd2hlbiB0aGUgZmlsZXR5cGUgaXMgbm90IG1hcHBhYmxlLgorCQkgKiBCeSBjYXB0
 dXJpbmcgdGhpcywgd2UgY2FuIG1ha2Ugc3VyZSBFSU5WQUwgaXMgZXhwb3J0ZWQKKwkJICogaWZm
 IHRoZSBvcmlnaW5hbCBuYW1lIGFyZ3VtZW50IGlzIE5VTEwuCisJCSAqLworCQlpZiAoZXJybm8g
 PT0gRUlOVkFMKQorCQkJc2F2ZWRfZXJybm8gPSBFRlRZUEU7CisJCWVsc2UKKwkJCXNhdmVkX2Vy
 cm5vID0gZXJybm87CiAJCV9jbG9zZShmZCk7CiAJCVNBVkVGQUlMKG5hbWUsIGxhbmcsIHNhdmVk
 X2Vycm5vKTsKIAkJTkxSRVRFUlIoc2F2ZWRfZXJybm8pOwo=
 --f46d04339c4cf73c4604cc3d4023--