12-stable buildworld appears to be broken

[Hans Ottevanger]

On 3/7/19 8:29 AM, Trond Endrestøl wrote:
> On Thu, 7 Mar 2019 05:13-0000, tech-lists wrote:
> 
>> Hi,
>>
>> My context is poudriere creating jails on freebsd12-stable. This procedure
>> worked fine for some other jails I created a couple days ago (the 5th) but
>> now, today I get buildworld failures with creating either amd64 or armv7 jails
>> (the server is amd64)
>>
>> To try to see the failure, I set jobs to J1 like so:
>>
>> poudriere jail -x -J1 -c -j 12armv7 -a arm.armv7 -m svn+https -v
>> stable/12
>>
>> It bails when it's making rescue with this error:
>>
>> /data/poudriere/basefs/jails/12armv7/usr/src/sbin/fsck_ffs/pass1.c:454:13:
>> error: too many arguments to function call, expected 0, have 1
>>                         inodirty(dp);
>>                         ~~~~~~~~ ^~
>> /data/poudriere/basefs/jails/12armv7/usr/src/sbin/fsck_ffs/fsck.h:453:1:
>> note: 'inodirty' declared here
>> void inodirty(void); ^
>> 1 error generated.
>> *** [pass1.o] Error code 1
>>
>> I know that's probably not enough, so have pasted much more output at
>> https://rpi3.zyxst.net/errors/poudriere-build-failure.txt
>>
>> not tried make buildworld yet on the host. The OS is at r344763 and
>> /usr/src is at 344863
>>
>> Just tried it on another 12-stable desktop, straightforward make
>> buildworld, same sort of error:
>>
>> --- all_subdir_sbin/fsdb ---
>> /usr/src/sbin/fsdb/fsdb.c:1042:14: error: too many arguments to function
>> call, expected 0, have 1
>>     inodirty(curinode);
>>         ~~~~~~~~ ^~~~~~~~         /usr/src/sbin/fsck_ffs/fsck.h:453:1: note:
>> 'inodirty' declared
>>         here
>>         void            inodirty(void);
>>
>> the sources are at 344869
> 
> It's good to see I'm not the only one experiencing this issue. It
> looks like r339941 was never merged to stable/12.
>

FWIW, the same happens in stable/11 (r344876).

Kind regards,

Hans Ottevanger