Kernel build fails

Dries Michiels driesm.michiels at gmail.com
Thu Jul 5 11:58:53 UTC 2018


> > --- kern_jail.o ---
> >
> > /usr/src/sys/kern/kern_jail.c:3943:15: error: unused variable 'p'
> > [-Werror,-Wunused-variable]
> >
> >         struct proc *p;
> >
> >                      ^
> >
> > /usr/src/sys/kern/kern_jail.c:3944:16: error: unused variable 'cred'
> > [-Werror,-Wunused-variable]
> >
> >         struct ucred *cred;
> >
> >                       ^
> >
> > 2 errors generated.
> 
> You have RACCT but not RCTL in the kernel config ?  Try this.

This is correct!

> diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c index
> b8bcbd49420..457a590cdf5 100644
> --- a/sys/kern/kern_jail.c
> +++ b/sys/kern/kern_jail.c
> @@ -3988,8 +3988,10 @@ prison_racct_attach(struct prison *pr)  static
> void  prison_racct_modify(struct prison *pr)  {
> +#ifdef RCTL
>  	struct proc *p;
>  	struct ucred *cred;
> +#endif
>  	struct prison_racct *oldprr;
> 
>  	ASSERT_RACCT_ENABLED();

I'm trying the patch as we speak thanks kib.
Atlough after some digging I see that the kernel option RACCT on itself
isn't really useful and should probably be combined with RCTL.
Do you agree?



More information about the freebsd-stable mailing list