ctld: only 579 iSCSI targets can be created

[Edward Tomasz Napierała]

On 0922T1036, Eugene M. Zheganin wrote:
> Hi,
> 
> I have old 11-STABLE as an iSCSI server, but out of the blue I 
> encountered weird problem: only 579 targets can be created. I mean, I am 
> fully aware that the out-of-the-box limit is 128 targets, with is 
> enforced by the CTL_MAX_PORTS define, and I've set it to 1024 (and of 
> course rebuilt and installed a new kernel), but when I add more that 579 
> targets I start to get the protocol errors:
> 
> Sep 22 10:16:48 san1 ctld[8657]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x4
> Sep 22 10:16:48 san1 ctld[8658]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x46
> Sep 22 10:17:31 san1 ctld[8746]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x4
> Sep 22 10:17:31 san1 ctld[8747]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x46
> Sep 22 10:19:58 san1 ctld[9190]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x4
> Sep 22 10:19:58 san1 ctld[9191]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x46
> Sep 22 10:21:33 san1 ctld[9518]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x4
> Sep 22 10:21:33 san1 ctld[9519]: 10.0.3.127 
> (iqn.1991-05.com.microsoft:worker296): protocol error: received invalid 
> opcode 0x46

There are two weird things here.  First is that the error is coming from
ctld(8) - the userspace daemon, not the kernel.  The second is that those
invalid opcodes are actually both valid - they are the Text Request,
and the Logout Request with Immediate flag set, exectly what you'd expect
for a discovery session.

Do you have a way to do a packet dump?