make installworld creates empty dirs which are deleted by make delete-old

[Miroslav Lachman]

Miroslav Lachman wrote on 01/16/2016 14:28:
> Philippe Michel wrote on 01/16/2016 13:51:
>> On Sat, 16 Jan 2016, freebsd-stable-request at freebsd.org wrote:
>>
>>> I updated the server 3 times in one week (to 10.2-p8, -p9, -p10).
>>
>>> Those directories were deleted by delete-old
>>>
>>> # make -DBATCH_DELETE_OLD_FILES delete-old
>>> >>> Removing old files (only deletes safe to delete libs)
>>> >>> Old files removed
>>> >>> Removing old directories
>>> /usr/share/doc/atf
>>> /usr/share/atf
>>> /usr/include/atf-c++
>>> /usr/include/atf-c
>>> >>> Old directories removed
>>> To remove old libraries run 'make delete-old-libs'.
>>>
>>> By after next installworld, they are back.
>>
>> You build world WITHOUT_TESTS=true, don't you ?
>>
>> There are many of these flags that are somehow missed when creating
>> directories at install.
>
> I don't use WITHOUT flags for buildworld / installwordl. The only
> WITHOUT is one for kernel:
> WITHOUT_KERNEL_SYMBOLS=yes

[...]

>> I think some similar cases were fixed a few months ago by NGie Cooper
>> but it was apparently those he stumbled on by himself or some specific
>> bug reports rather than the start of a more exhaustive sweep.
>>
>> I suppose opening a PR could have helped but I procrastinated :-(.
>
> OK, I will open PR for this today.
>
> Thank you for your suggestions.

I found a half year old PR for this

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201072

Miroslav Lachman