smbfs crashes since approx. 10.1-RELEASE

[Christian Kratzer]

Hi Rick,

On Sat, 10 Oct 2015, Rick Macklem wrote:

> Hi again,
>
> Attached is a semantically equivalent patch to the one I posted a few
> minutes ago, but I think this one is more readable.
>
> Please let me know if you get it tested, rick

the box crashed again tonight with your patch applied. Here's the new crashinfo:

     panic: Assertion mtx_unowned(m) failed at /usr/src/sys/kern/kern_mutex.c:955

     GNU gdb 6.1.1 [FreeBSD]
     Copyright 2004 Free Software Foundation, Inc.
     GDB is free software, covered by the GNU General Public License, and you are
     welcome to change it and/or distribute copies of it under certain conditions.
     Type "show copying" to see the conditions.
     There is absolutely no warranty for GDB.  Type "show warranty" for details.
     This GDB was configured as "amd64-marcel-freebsd"...

     Unread portion of the kernel message buffer:
     panic: Assertion mtx_unowned(m) failed at /usr/src/sys/kern/kern_mutex.c:955
     cpuid = 2
     KDB: stack backtrace:
     #0 0xffffffff80975bb0 at kdb_backtrace+0x60
     #1 0xffffffff8093baa6 at vpanic+0x126
     #2 0xffffffff8093b979 at kassert_panic+0x139
     #3 0xffffffff80921c47 at _mtx_destroy+0x77
     #4 0xffffffff81a1c114 at smb_iod_destroy+0xc4
     #5 0xffffffff81a12eea at smb_vc_free+0x1a
     #6 0xffffffff81a13e24 at sdp_trydestroy+0xb4
     #7 0xffffffff81a1cb36 at smbfs_unmount+0xd6
     #8 0xffffffff809d9e84 at dounmount+0x524
     #9 0xffffffff809d9936 at sys_unmount+0x3c6
     #10 0xffffffff80d42235 at amd64_syscall+0x265
     #11 0xffffffff80d25cfb at Xfast_syscall+0xfb
     Uptime: 1d21h59m0s
     Dumping 191 out of 999 MB:..9%..17%..26%..34%..42%..51%..67%..76%..84%..92%

Here are the stackframes with line numbers:

     (kgdb) frame 0
     #0  __curthread () at ./machine/pcpu.h:219
     219		__asm("movq %%gs:%1,%0" : "=r" (td)
     (kgdb) frame 1
     #1  doadump (textdump=<optimized out>) at /usr/src/sys/kern/kern_shutdown.c:263
     263		dumptid = curthread->td_tid;
     (kgdb) frame 2
     #2  0xffffffff8093b5f2 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:451
     451			doadump(TRUE);
     (kgdb) frame 3
     #3  0xffffffff8093bae5 in vpanic (fmt=<optimized out>, ap=<optimized out>) at /usr/src/sys/kern/kern_shutdown.c:758
     758		kern_reboot(bootopt);
     (kgdb) frame 4
     #4  0xffffffff8093b979 in kassert_panic (fmt=0xffffffff80e931ef "Assertion %s failed at %s:%d") at /usr/src/sys/kern/kern_shutdown.c:646
     646			vpanic(fmt, ap);
     (kgdb) frame 5
     #5  0xffffffff80921c47 in _mtx_destroy (c=0xfffff80002db5490) at /usr/src/sys/kern/kern_mutex.c:955
     955			MPASS(mtx_unowned(m));
     (kgdb) frame 6
     #6  0xffffffff81a1c174 in smb_iod_destroy (iod=0xfffff80002db5400) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:733
     733		smb_sl_destroy(&iod->iod_evlock);
     (kgdb) frame 7
     #7  0xffffffff81a12eea in smb_vc_free (cp=0xfffff80002933000) at /usr/src/sys/modules/smbfs/../../netsmb/smb_conn.c:499
     499			smb_iod_destroy(vcp->vc_iod);
     (kgdb) frame 8
     #8  0xffffffff81a13e24 in sdp_trydestroy (sdp=0xfffff80002904140) at /usr/src/sys/modules/smbfs/../../netsmb/smb_dev.c:166
     166			smb_vc_rele(vcp, scred);
     (kgdb) frame 9
     #9  0xffffffff81a1cb96 in smbfs_unmount (mp=0xfffff80015226000, mntflags=<optimized out>) at /usr/src/sys/modules/smbfs/../../fs/smbfs/smbfs_vfsops.c:297
     297		sdp_trydestroy(dev);
     (kgdb) frame 10
     #10 0xffffffff809d9e84 in dounmount (mp=0xfffff80015226000, flags=134217728, td=0xfffff800151b0940) at /usr/src/sys/kern/vfs_mount.c:1313
     1313			error = VFS_UNMOUNT(mp, flags);
     (kgdb)

Let me know if you need anything else from the stackframes.


Greetings
Christian


-- 
Christian Kratzer                   CK Software GmbH
Email:   ck at cksoft.de               Wildberger Weg 24/2
Phone:   +49 7032 893 997 - 0       D-71126 Gaeufelden
Fax:     +49 7032 893 997 - 9       HRB 245288, Amtsgericht Stuttgart
Mobile:  +49 171 1947 843           Geschaeftsfuehrer: Christian Kratzer
Web:     http://www.cksoft.de/