SOL_TCP def?

[Michael Sinatra]

On 12/29/15 10:28, Jonathan Chen wrote:
> Hi,
> 
> I've just recently updated on 10/STABLE to r292878; and on rebuilding
> devel/gsoap, I get:
> 
> cc -DHAVE_CONFIG_H -I. -I..       -DFREEBSD -O2 -pipe
> -fstack-protector -fno-strict-aliasing -MT libgsoap_a-stdsoap2.o -MD
> -MP -MF .deps/libgsoap_a-stdsoap2.Tpo -c -o libgsoap_a-stdsoap2.o
> `test -f 'stdsoap2.c' || echo './'`stdsoap2.c
> stdsoap2.c:5107:64: error: use of undeclared identifier 'SOL_TCP'
>   if (!(soap->omode & SOAP_IO_UDP) && setsockopt(soap->master,
> SOL_TCP, TCP_FASTOPEN, (char*)&set, sizeof(int)))

As Dmitry notes, you must patch both stdsoap2.c and stdsoap2.cpp to use
IPPROTO_TCP instead of SOL_TCP.  The reason for the change is that the
code looks to see if TCP_FASTOPEN is defined, and, if so, it assumes
that it's some sort of Linux-based stack that uses SOL_TCP instead of
IPPROTO_TCP.  Once TCP Fast Open (RFC 7413) was MFC'd to STABLE,
TCP_FASTOPEN became defined so gsoap tried to use it with the wrong
SOL_TCP definition.

michael