make tinderbox broken with LINT-NOINET on ref10-amd64.freebsd.org (if_gif compilation issues)

Andrey V. Elsukov ae at FreeBSD.org
Tue Dec 15 11:25:08 UTC 2015


On 14.12.15 19:58, Mariusz Zaborski wrote:
> On Mon, Dec 14, 2015 at 07:55:06PM +0300, Andrey V. Elsukov wrote:
>> On 14.12.15 19:51, Mariusz Zaborski wrote:
>>> On Mon, Dec 14, 2015 at 06:31:52AM -0800, NGie Cooper wrote:
>>>> Hi Andrey, Just a heads up that LINT-NOINET seems to be broken on
>>>> amd64/i386 with if_gif(4) on stable/10. Could you please fix this? 
>>>> Thanks, -NGie
>>> Hi,
>>>
>>> I already found the problem we need to MFC r276224 and r277130.
>>
>> I don't think r277130 is related to this problem.
>> I have this patch and I'm trying to build with them.
> Not with this but after fixing r276224 it will crash in other place which
> r277130 is fixing. :)

Actually, I don't think that my patch will work correctly.
opt_inet.h can contain several options in addition to INET. In such case
the expression

OPT_INET!= cat ${KERNBUILDDIR}/opt_inet.h; echo
.if empty(OPT_INET)

will always be true. Are you sure merging of r276224 it works as expected?

Probably, this patch will work correctly:


-- 
WBR, Andrey V. Elsukov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modules.diff
Type: text/x-patch
Size: 1037 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20151215/df802697/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20151215/df802697/attachment.sig>


More information about the freebsd-stable mailing list