Possible Error in the FreeBSD 10.2 Release Notes/Man page for TCP

[Glen Barber]

On Wed, Aug 12, 2015 at 03:54:42PM -0700, Sean Bruno wrote:
> On 08/12/15 15:43, Glen Barber wrote:
> > On Wed, Aug 12, 2015 at 03:41:21PM -0700, Sean Bruno wrote:
> >> On 08/12/15 15:15, Glen Barber wrote:
> >>> On Wed, Aug 12, 2015 at 01:09:31PM -0500, dweimer wrote:
> >>>> I was reading through the Release notes, and decided to
> >>>> enable net.inet.tcp.pmtud_blackhole_detection in my test
> >>>> environment. It appears that the monitoring tunable 
> >>>> net.inet.tcp.pmtud_blackhole_min_activated is incorrectly
> >>>> listed. Using sysctl -a | grep net.inet.tcp.pmtud, doesn't
> >>>> show it as a result. The test system is running RC3 built on
> >>>> the 7th from revision 286391 of the
> >>>> https://svn.freebsd.org/base/releng/10.2 tree.
> >>>> 
> >>>> root at freebsd:/usr/src # sysctl -a | grep net.inet.tcp.pmtud 
> >>>> net.inet.tcp.pmtud_blackhole_mss: 1200 
> >>>> net.inet.tcp.pmtud_blackhole_failed: 0 
> >>>> net.inet.tcp.pmtud_blackhole_activated_min_mss: 0 
> >>>> net.inet.tcp.pmtud_blackhole_activated: 0 
> >>>> net.inet.tcp.pmtud_blackhole_detection: 1
> >>>> 
> >>>> I did confirm that the pmtud_blackhole_min_activated option
> >>>> is also listed in the tcp(4) man page page as well.
> >>>> 
> >>>> If anyone is more familiar with this than I am can they look
> >>>> into seeing if there is indeed an error, or if I am missing
> >>>> something here.
> >>>> 
> >>> 
> >>> This appears to be an error based on the content of the commit 
> >>> log. I will confirm with the person that committed the code,
> >>> and will note the findings in the 10.2-RELEASE errata
> >>> document.
> >>> 
> >> 
> >> This looks like I failed to MFC r276345 to stable 10 in order to 
> >> update tcp.4 leading to this confusion.
> >> 
> > 
> > Thank you for confirming.  I'll update the 10.2-RELEASE errata 
> > accordingly.
> > 
> > What should the proper sysctls be, for completeness?
> > 
> > Glen
> > 
> 
> % sysctl -a|grep pmtud
> net.inet.tcp.v6pmtud_blackhole_mss: 1220
> net.inet.tcp.pmtud_blackhole_mss: 1200
> net.inet.tcp.pmtud_blackhole_failed: 0
> net.inet.tcp.pmtud_blackhole_activated_min_mss: 0
> net.inet.tcp.pmtud_blackhole_activated: 0
> net.inet.tcp.pmtud_blackhole_detection: 0
> 
> 
> These are correct.  The man page is now updated as of svn r286706.
> 

Thank you.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20150812/9547b34b/attachment.bin>