Holdover error in /usr/src/Makefile.inc1

[Glen Barber]

On Sun, Dec 15, 2013 at 11:43:47PM +0000, Thomas Mueller wrote:
> > On Sun, Dec 15, 2013 at 06:48:42AM +0000, Thomas Mueller wrote:
> > > In Makefile in the top directory of the source tree, there is a part that
> > > appears to be in error, a holdover from before HEAD-10 branched into STABLE-10
> > > and HEAD-11:
> 
> > > SVN?=         /usr/local/bin/svn
> > > SVNFLAGS?=    -r HEAD
> 
> > > I guess they forgot to change that line?
> 
> > Which one?
> 
> > '-r HEAD' refers to 'HEAD' (or latest revision) of the top of the tree
> > (in the case of stable/10, it would be stable/10 at rHEAD).
> 
> 
> Sorry, I forgot to be clearer.
> 
> SVN and SVNFLAGS lines are in $SRCDIR/Makefile.inc1 for both HEAD and stable/10.
> 
> Quite appropriate for HEAD, but not for stable/10.
> 
> It seems to me "SVNFLAGS?= -r HEAD" would switch stable/10 source tree to HEAD.  Right or wrong?
> 

Wrong.  '-rHEAD' is the 'HEAD' *revision*, not branch.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20131215/cce6606c/attachment.sig>