busdma MFC broke ipfw fwd for RELENG_6

Eugene Grosbein egrosbein at rdtc.ru
Fri Sep 16 04:45:35 UTC 2011


16.09.2011 02:19, YongHyeon PYUN пишет:
> On Fri, Sep 16, 2011 at 02:02:37AM +0700, Eugene Grosbein wrote:
>> 16.09.2011 01:15, YongHyeon PYUN пишет:
>>
>>> I remember re(4) in 6.x also have a couple of bus_dma(9) bugs. How
>>> about applying the following revision?
>>> http://svnweb.freebsd.org/base?view=revision&revision=175337
>>> Not sure whether it shall apply cleanly.
>>
>> It does not and there is too much differences in the code for my skills to apply manually :-)
>>
>>> Alternatively try replacing BUS_DMA_ALLOCNOW to 0 in
>>> bus_dma_tag_create(9).
>>
>> I'm not sure I undersdand this right... Do you mean this change?
> 
> No, change BUS_DMA_ALLOCNOW used in re(4).

With clean RELENG_6 sources and the only following patch,
the problem still persists.

--- if_re.c.orig        2008-03-02 21:54:48.000000000 +0700
+++ if_re.c     2011-09-16 11:37:30.000000000 +0700
@@ -1077,7 +1077,7 @@
        nseg = 32;
        error = bus_dma_tag_create(sc->rl_parent_tag, ETHER_ALIGN, 0,
            BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL,
-           NULL, MCLBYTES * nseg, nseg, MCLBYTES, BUS_DMA_ALLOCNOW,
+           NULL, MCLBYTES * nseg, nseg, MCLBYTES, 0,
            NULL, NULL, &sc->rl_ldata.rl_mtag);
        if (error) {
                device_printf(dev, "could not allocate dma tag\n");


More information about the freebsd-stable mailing list