panic: spin lock held too long (RELENG_8 from today)

[Trent Nelson]

On Aug 19, 2011, at 7:53 PM, Attilio Rao wrote:

> If nobody complains about it earlier, I'll propose the patch to re@ in 8 hours.

Just a friendly 'me too', for the records.  22 hours of heavy network/disk I/O and no panic yet -- prior to the patch it was a panic orgy.

Any response from re@ on the patch?  It didn't appear to be in stable/8 as of yesterday:

[root at flanker/ttypts/0(../src/sys/kern)#] svn diff
Index: kern_timeout.c
===================================================================
--- kern_timeout.c	(revision 225280)
+++ kern_timeout.c	(working copy)
@@ -268,9 +268,11 @@
 	CC_LOCK_ASSERT(cc);
 
 	c->c_cpu = CPUBLOCK;
+	spinlock_enter();
 	CC_UNLOCK(cc);
 	new_cc = CC_CPU(new_cpu);
 	CC_LOCK(new_cc);
+	spinlock_exit();
 	c->c_cpu = new_cpu;
 	return (new_cc);
 }


Regards,

	Trent.