csup in repomirror mode dumps core @ stable/8

[John Hay]

On Thu, Sep 02, 2010 at 03:59:07AM +0400, Dmitry Morozovsky wrote:
> Dear colleagues,
> 
> some 2 days ago my repo mirror (stable/8 at amd64) starts dumping core on copying 
> repo:
> 
> ...
>  SetAttrs CVSROOT-src/Emptydir
>  Edit CVSROOT-src/access,v
> Segmentation fault (core dumped)
> 
> deleting files from sup/cvsroot-all/ did not help
> 
> unfortunately, quick usual `make -DDEBUG_FLAGS=-g' in /usr/src/usr.bin/csup 
> does not work, and I did not dig into this deeply yet, so trace are without 
> parameters:
> 
> (gdb) bt
> #0  0x0000000000410676 in rcsdelta_addlog ()
> #1  0x0000000000412b15 in rcsparse_run ()
> #2  0x0000000000412453 in rcsfile_frompath ()
> #3  0x0000000000417c45 in updater_rcsedit ()
> #4  0x0000000000419a59 in updater_batch ()
> #5  0x000000000041a1d1 in updater ()
> #6  0x00000000004158c4 in thread_start ()
> #7  0x0000000800a1c511 in pthread_getprio () from /lib/libthr.so.3
> #8  0x0000000000000000 in ?? ()
> Cannot access memory at address 0x7fffff1fa000
> 

I see it here too on both a 7.2 and 8-stable machine. It looks like
something in CVSROOT-src/access,v confuse it because moving that file
away make the crash go away. I still have the old access,v if somebody
is interested. A diff does not show anything wierd that I can see.

John
-- 
John Hay -- jhay at meraka.csir.co.za / jhay at FreeBSD.org


--- /tmp/access,v-csup.crash	2010-07-31 16:57:51.000000000 +0200
+++ /home/freebsd-cvs/CVSROOT-src/access,v	2010-08-30 22:31:11.000000000 +0200
@@ -1,10 +1,15 @@
-head	1.941;
+head	1.942;
 access;
 symbols;
 locks; strict;
 comment	@# @;
 
 
+1.942
+date	2010.08.30.20.30.48;	author rpaulo;	state Exp;
+branches;
+next	1.941;
+
 1.941
 date	2010.07.31.14.57.38;	author philip;	state Exp;
 branches;
@@ -4715,11 +4720,13 @@
 @@
 
 
-1.941
+1.942
 log
- at SVN rev 210685 on 2010-07-31 14:57:38Z by philip
+ at SVN rev 212009 on 2010-08-30 20:30:48Z by rpaulo
 
-Take cbzimmer's commit bit into safekeeping per his request.
+Please welcome Dimitry Andric (dim@@) as a src committer. Dimitry will be
+work on Clang for now.
+ed@@ is a co-mentor.
 
 Approved by:	core
 @
@@ -4789,6 +4796,7 @@
 des
 dfr
 dg
+dim
 dougb
 dumbbell
 dwhite
@@ -4972,6 +4980,19 @@
 @
 
 
+1.941
+log
+ at SVN rev 210685 on 2010-07-31 14:57:38Z by philip
+
+Take cbzimmer's commit bit into safekeeping per his request.
+
+Approved by:	core
+@
+text
+ at d66 1
+@
+
+
 1.940
 log
 @SVN rev 210462 on 2010-07-25 10:06:56Z by philip