regression with jexec?

[Michael Butler]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jamie Gritton wrote:
> Michael Butler wrote:
>> imb at aaron:/home/imb> sudo jexec 5 tcsh
>> jexec: Unable to parse jail ID.: No such file or directory

> 
> The symptom in jexec can be fixed by this little patch:
> 
> Index: usr.sbin/jexec/jexec.c
> ===================================================================
> --- usr.sbin/jexec/jexec.c    (revision 195879)
> +++ usr.sbin/jexec/jexec.c    (working copy)
> @@ -248,6 +248,7 @@
>      if (argc < 2)
>          usage();
>      if (strlen(argv[0]) > 0) {
> +        errno = 0;
>          jid = (int)strtol(argv[0], NULL, 10);
>          if (errno)
>              err(1, "Unable to parse jail ID.");

Thanks - this certainly cures the effect.

> But the broader problem is malloc.  It's leaving errno set to
> ENOENT when /etc/malloc.conf doesn't exist.  This seems like
> wrong behavior to me.

Seems like a POLA violation to me,

	imb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkprrBoACgkQQv9rrgRC1JIImwCdG2hjH00hKOzMRUHEqfXwu8FS
O6UAoJL/2iZf/Nz0Pp84q0p+RDkNIM+1
=iBx1
-----END PGP SIGNATURE-----