hang of new usb stack [was Re: Patch for boot-time USB hangs in 4.9-PRERELEASE]

[Josef Karthauser]

On Mon, Oct 06, 2003 at 09:15:17PM +0200, Tijl Coosemans wrote:
> On Sun, 5 Oct 2003 20:08:22 +0100, Josef Karthauser wrote:
> 
> > On Sat, Sep 27, 2003 at 02:05:51PM +0100, Ian Dowse wrote:
> > > 
> > > Could people who are experiencing boot-time hangs in 4.9-PRERELEASE
> > > try the following patch to see if it helps? I've had one positive
> > > report so far, but it would be helpful to get more feedback to
> > > determine if this is the right fix to be committed.
> > 
> > I'm interested in whether this fix also fixes the boot time handing of
> > the new usb stack.  Perhaps any interested parties could test it and
> > let me know?
> > 
> > The new usb patch to RELENG_4 as of today is at:
> > 
> >     http://www.josef-k.net/misc/RELENG_4-USB-20031005.patch.gz
> 
> I get the following error during a make buildworld:
> 
> ===> usr.sbin/usbdevs
> cc -O2 -pipe -march=pentium -I/usr/src/usr.sbin/usbdevs/../../sys -c
> /usr/src/usr.sbin/usbdevs/usbdevs.c
> /usr/src/usr.sbin/usbdevs/usbdevs.c: In function `usbdev':
> /usr/src/usr.sbin/usbdevs/usbdevs.c:91: structure has no member named
> `udi_lowspeed'
> *** Error code 1

You're right!  I didn't add the usb tools to that patch set.  I'll make
sure that they are there for the next one.

In the mean time I've attached the patch to usbdevs.c that you want.

Joe
-- 
Josef Karthauser (joe at tao.org.uk)	       http://www.josef-k.net/
FreeBSD (cvs meister, admin and hacker)     http://www.uk.FreeBSD.org/
Physics Particle Theory (student)   http://www.pact.cpes.sussex.ac.uk/
================ An eclectic mix of fact and theory. =================
-------------- next part --------------
Index: usbdevs.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/usbdevs/usbdevs.c,v
retrieving revision 1.5.2.3
diff -u -r1.5.2.3 usbdevs.c
--- usbdevs.c	13 Nov 2002 15:15:21 -0000	1.5.2.3
+++ usbdevs.c	11 Oct 2003 11:49:07 -0000
@@ -64,7 +64,7 @@
 void
 usage()
 {
-	fprintf(stderr, "Usage: %s [-a addr] [-d] [-f dev] [-v]\n",
+	fprintf(stderr, "usage: %s [-a addr] [-d] [-f dev] [-v]\n",
 	    getprogname());
 	exit(1);
 }
@@ -88,8 +88,12 @@
 	printf("addr %d: ", a);
 	done[a] = 1;
 	if (verbose) {
-		if (di.udi_lowspeed)
-			printf("low speed, ");
+		switch (di.udi_speed) {
+		case USB_SPEED_LOW:  printf("low speed, "); break;
+		case USB_SPEED_FULL: printf("full speed, "); break;
+		case USB_SPEED_HIGH: printf("high speed, "); break;
+		default: break;
+		}
 		if (di.udi_power)
 			printf("power %d mA, ", di.udi_power);
 		else
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20031011/882a9a9c/attachment.bin