FreeBSD Security Advisory FreeBSD-SA-05:02.sendfile

[Marc Olzheim]

On Tue, Apr 05, 2005 at 10:14:16AM +0200, Uwe Doering wrote:
> I can't tell why 'ovp' was introduced in the first place.  Might have 
> historical reasons.  But that's how the code currently works.  In the 
> MAIN branch as well, according to CVS.  So I'd suggest to replace 'vp' 
> with 'ovp' in the patch above, for the sake of clarity and consistency.

It's a remnant from sys/ufs/ffs/ffs_inode.c:1.27 - 1.28, when the
arguments of ffs_truncate changed from (ap), to (vp, length, flags,
cred, p) and ovp was declared as
'register struct vnode *vp = ap->a_vp;'.

This could be cleaned up without problems.

Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-security/attachments/20050406/8eb6eeb6/attachment.bin