[Bug 229551] src/sys/dev/trm/trm.c:2484: bad if logic

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Feb 16 00:53:23 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229551

Andriy Voskoboinyk <avos at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |avos at freebsd.org
             Status|New                         |Open
           Keywords|                            |patch
           Assignee|bugs at FreeBSD.org            |scsi at FreeBSD.org

--- Comment #1 from Andriy Voskoboinyk <avos at freebsd.org> ---
I assume that

(pDCB->DevMode & TAG_QUEUING_) && (pDCB->DevMode & EN_DISCONNECT_)

should be changed to

((pDCB->DevMode & TAG_QUEUING_) || (pDCB->DevMode & EN_DISCONNECT_))

however, I don't think this fix should be committed to the tree without testing
with real device and / or specs verification.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-scsi mailing list