[Bug 233654] isp(4) regression after r316398 r316399

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Dec 18 06:57:37 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233654

--- Comment #3 from aler at playground.ru ---
Pre-316398 code only uses MSI-X for 2600+ cards.

This change in new code seems to fix the problem. May be it will be better to
add some sysctl to optionally allow MSI-X on 24xx but anyway it should be
disabled by default and might be enabled only by explicit request.


--- sys/dev/isp/ispmbox.h.orig  2018-12-18 09:49:17.549288000 +0300
+++ sys/dev/isp/ispmbox.h       2018-12-17 04:12:14.056837000 +0300
@@ -896,7 +896,7 @@
 #define        ISP_GET_VPIDX(isp, tag) \
        (ISP_CAP_MULTI_ID(isp) ? tag : 0)
 #define        ISP_CAP_MSIX(isp)       \
-       (IS_24XX(isp)? (isp->isp_fwattr & ISP2400_FW_ATTR_MSIX) : 0)
+       (IS_26XX(isp)? (isp->isp_fwattr & ISP2400_FW_ATTR_MSIX) : 0)
 #define        ISP_CAP_VP0(isp)        \
        (IS_24XX(isp)? (isp->isp_fwattr & ISP2400_FW_ATTR_VP0) : 0)

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-scsi mailing list