GEOM probes fail on aac with EARLY_AP_STARTUP

[Scott Long]

> On Sep 8, 2017, at 11:06 AM, john hood <cgull at glup.org> wrote:
> 
> On 9/8/17 9:15 AM, sthaug at nethelp.no wrote:
>> Is there any reason to believe this is limited to aac? I'm asking
>> because your description is quite similar to boot problema I'm seeing
>> with 11.1-STABLE on a server with mps (Avago) SCSI/SATA controller
>> and SATA disks. I'm getting the dreaded "mounting from ... failed
>> with error 19". 11.1-RELEASE seems to work okay but 11.1-STABLE does
>> not.
> 
> Your issue isn't obviously directly related to mine. mps is a CAM driver
> and aac is not (at least not for normal block volumes), which makes disk
> probe/attach quite different.  I also don't see an obvious driver flag
> like the one in aac.
> 

It’s a different pattern in CAM, and CAM itself looks to be safe.  MPS and MPR
have their own intrhooks, and on review just now I see a potential for a similar
problem to what you saw and that would match Steinar’s symptoms.  Please
try the following patch:

--- mps.c	(revision 323314)
+++ mps.c	(working copy)
@@ -1639,6 +1639,11 @@
 	mps_mapping_initialize(sc);
 	mpssas_startup(sc);
 	mps_unlock(sc);
+
+	mps_dprint(sc, MPS_XINFO, "disestablish config intrhook\n");
+	config_intrhook_disestablish(&sc->mps_ich);
+	sc->mps_ich.ich_arg = NULL;
+
 	mps_dprint(sc, MPS_INIT, "%s exit\n", __func__);
 }
 
Index: mps_sas.c
===================================================================
--- mps_sas.c	(revision 323314)
+++ mps_sas.c	(working copy)
@@ -3695,11 +3695,6 @@
 		mps_dprint(sc, MPS_FAULT, "Portenable failed\n");
 
 	mps_free_command(sc, cm);
-	if (sc->mps_ich.ich_arg != NULL) {
-		mps_dprint(sc, MPS_XINFO, "disestablish config intrhook\n");
-		config_intrhook_disestablish(&sc->mps_ich);
-		sc->mps_ich.ich_arg = NULL;
-	}
 
 	/*
 	 * Get WarpDrive info after discovery is complete but before the scan