Intel C600 SAS Controller + locate LED (SGPIO)

[Jim Harris]

On Wed, Sep 26, 2012 at 2:37 AM, Paul Maulberger <Paul.Maulberger at gmx.de> wrote:
> Hi Jim,
>
> your patch is working very well. Thanks a lot!
>
> To support the locate and the fault led I extended your patch a little bit. Like the ahci driver every port has now a locate and a fault led device.

Hi Paul,

I am reluctant to add LEDs for error, even though I know AHCI driver
does this today.  I don't see the need for userspace to manipulate
both locate and error LEDs - it seems locate is sufficient.  I'd
prefer to keep error LED reserved for future use in the driver.

But I will add "locate" to the LED name, just to make it more clear.

> # ls -al /dev/led
> total 1
> dr-xr-xr-x   2 root  wheel       512 Sep 26 08:39 .
> dr-xr-xr-x  11 root  wheel       512 Sep 26 10:39 ..
> crw-------   1 root  wheel    0,  47 Sep 26 08:43 ahcich0.fault
> crw-------   1 root  wheel    0,  46 Sep 26 08:44 ahcich0.locate
> crw-------   1 root  wheel    0,  49 Sep 26 08:39 ahcich1.fault
> crw-------   1 root  wheel    0,  48 Sep 26 08:39 ahcich1.locate
> crw-------   1 root  wheel    0,  51 Sep 26 08:39 ahcich2.fault
> crw-------   1 root  wheel    0,  50 Sep 26 08:39 ahcich2.locate
> crw-------   1 root  wheel    0,  53 Sep 26 08:39 ahcich3.fault
> crw-------   1 root  wheel    0,  52 Sep 26 08:39 ahcich3.locate
> crw-------   1 root  wheel    0,  55 Sep 26 08:39 ahcich4.fault
> crw-------   1 root  wheel    0,  54 Sep 26 08:39 ahcich4.locate
> crw-------   1 root  wheel    0,  57 Sep 26 08:44 ahcich5.fault
> crw-------   1 root  wheel    0,  56 Sep 26 08:44 ahcich5.locate
> crw-------   1 root  wheel    0,  36 Sep 26 08:39 igb0
> crw-------   1 root  wheel    0,  37 Sep 26 08:39 igb1
> crw-------   1 root  wheel    0,  38 Sep 26 08:39 isci.bus0.port0.fault
> crw-------   1 root  wheel    0,  39 Sep 26 08:39 isci.bus0.port0.locate
> crw-------   1 root  wheel    0,  40 Sep 26 08:42 isci.bus0.port1.fault
> crw-------   1 root  wheel    0,  41 Sep 26 08:42 isci.bus0.port1.locate
> crw-------   1 root  wheel    0,  42 Sep 26 08:39 isci.bus0.port2.fault
> crw-------   1 root  wheel    0,  43 Sep 26 08:39 isci.bus0.port2.locate
> crw-------   1 root  wheel    0,  44 Sep 26 08:39 isci.bus0.port3.fault
> crw-------   1 root  wheel    0,  45 Sep 26 08:39 isci.bus0.port3.locate
>
> By the way the main board X9DRi-F has only one bus. The X9DR3-F has 2 buses.
>
> The patch (compared to 9.1 RC1) is attached.
>
> Is it possible to commit this patch into 9.1 or is it too late?

I think it is too late.  The changes here are very low risk, but it is
a new feature and not a bug fix so not really appropriate for 9.1 at
this point.

Thank you for testing the patch!

Regards,

-Jim


> Regards
> Paul
>
> Hint: If anybody is using a SC825TQ chassis and no led is blinking check ALL jumper settings of your backplane (Appendix C of http://www.supermicro.com/manuals/chassis/2U/SC825.pdf). Our backplane was wrongly configured by factory (mixture of sgpio and i2c settings).
>
>