CTL panic

[Chuck Tuffli]

On Thu, Mar 8, 2012 at 1:14 PM, Kenneth D. Merry <ken at freebsd.org> wrote:
> On Thu, Feb 23, 2012 at 13:44:10 -0800, Chuck Tuffli wrote:
>> I just tried using our targ(9) compatible driver with CTL today and
>> get the below panic. Our driver didn't recognize the
>> XPT_IMMEDIATE_NOTIFY and returned CAM_REQ_INVALID which ctlfedone
>> doesn't handle explicitly. The following patch seems to avoid this
>> problem for me, but there might be a better fix.
>
> Sorry for the delayed response.

No worries

> Here is a patch that should fix it.  Although it isn't relevant for you
> now, since your driver is talking to CTL successfully, it is still needed
> for the mpt(4), ahc(4), ahd(4), and firewire drivers that support the older
> target mode API.
>
> This hopefully fixes some of the issues inside CTL, and then essentially
> prevents CTL from talking to target-capable SIMs that haven't been updated
> to support the CCBs that CTL needs.

I tested this patch using our driver both
 - with PIT_PROCESSOR set and no XPT_IMMEDIATE_NOTIFY support
 - with PIT_PROC_CTL set and XPT_IMMEDIATE_NOTIFY support

and both work as expected. So patch-wise, ACK / "works for me"

---chuck