[patch] MFI should set bio_resid on command failure
Sean Bruno
seanbru at yahoo-inc.com
Tue Jul 3 18:42:21 UTC 2012
On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote:
> When an MFI command fails, the driver needs to set bio->bio_resid so that the upper levels notice. Otherwise we see commands silently failing leading to data corruption. This mirrors dadone().
>
> -Andrew
>
> Index: sys/dev/mfi/mfi_disk.c
> ===================================================================
> --- sys/dev/mfi/mfi_disk.c (revision 238071)
> +++ sys/dev/mfi/mfi_disk.c (working copy)
> @@ -298,6 +298,7 @@
> hdr = bio->bio_driver1;
>
> if (bio->bio_flags & BIO_ERROR) {
> + bio->bio_resid = bio->bio_bcount;
> if (bio->bio_error == 0)
> bio->bio_error = EIO;
> disk_err(bio, "hard error", -1, 1);
>
> --------------------------------------------------
> Andrew Boyer aboyer at averesystems.com
>
This looks right to me. It mirrors the behavior in mfi_disk_strategy()
as well.
Sean
More information about the freebsd-scsi
mailing list