kern/151564: [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 107

Thu Dec 20 15:20:01 UTC 2012

The following reply was made to PR kern/151564; it has been noted by GNATS.

From: "xenophon\\+freebsd" <xenophon+freebsd at irtnog.org>
To: <bug-followup at FreeBSD.org>,
	<leon.kos at lecad.fs.uni-lj.si>,
	<freebsd-scsi at freebsd.org>
Cc:  
Subject: Re: kern/151564: [ciss] ciss(4) should increase  CISS_MAX_LOGICAL to 107
Date: Thu, 20 Dec 2012 10:10:37 -0500

 This is a multi-part message in MIME format.

 ------_=_NextPart_001_01CDDEC4.2B270089
 Content-Type: text/plain;
 	charset="us-ascii"
 Content-Transfer-Encoding: quoted-printable

 All:

 I've created a patch (see attached) for the ciss driver that makes the
 following changes:

 *	creates a boot-time tunable (hw.ciss.max_logical) that allows
 changing the maximum number of logical drives (defaults to
 CISS_MAX_LOGICAL, which currently is 15 according to
 src/sys/dev/ciss/cissvar.h)

 *	changes the behavior of another boot-time tunable
 (hw.ciss.expose_hidden_physical) such that a value of 2 exposes hidden
 physical direct access devices as da(4) devices, where a value of 1
 retains the original behavior of exposing them only as pass(4) devices

 *	updates the ciss(4) manual page regarding the above
 modifications

 Would a committer be willing to review this patch for potential
 inclusion into some future release of FreeBSD?  I hereby place this
 patch into the public domain.

 I tested this successfully using FreeBSD/x86 9.0-RELEASE-p5 on an HP
 ProLiant DL380 G3 with an on-board Smart Array 5i controller.  For
 example, I have 20 single-disk RAID-0 arrays.  Without the patch, the
 ciss driver returns the error "adapter claims to report absurd number of
 logical drives".  With the patch applied and hw.ciss.max_logical set to
 32 in /boot/loader.conf, the ciss driver correctly detects and
 configures all twenty logical drives.  Furthermore, with
 hw.ciss.expose_hidden_physical to 2, the ciss driver also correctly
 exposes the physical disks underlying each of the 20 arrays as da(4)
 devices.

 I plan to test this patch next week using FreeBSD/amd64 on a DL380 G4,
 which has similar specs to my G3.

 Best wishes,
 Matthew

 --=20
 I FIGHT FOR THE USERS

 ------_=_NextPart_001_01CDDEC4.2B270089
 Content-Type: application/octet-stream;
 	name="ciss-tunable-maxlogical-exposehidden-da.patch"
 Content-Transfer-Encoding: base64
 Content-Description: ciss-tunable-maxlogical-exposehidden-da.patch
 Content-Disposition: attachment;
 	filename="ciss-tunable-maxlogical-exposehidden-da.patch"

 SW5kZXg6IHN5cy9kZXYvY2lzcy9jaXNzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2Rldi9jaXNzL2Np
 c3MuYwkocmV2aXNpb24gMjQ0MzYxKQorKysgc3lzL2Rldi9jaXNzL2Npc3MuYwkod29ya2luZyBj
 b3B5KQpAQCAtMjQ1LDYgKzI0NSw5IEBACiAvKgogICogVGhpcyB0dW5hYmxlIGNhbiBiZSBzZXQg
 YXQgYm9vdCB0aW1lIGFuZCBjb250cm9scyB3aGV0aGVyIHBoeXNpY2FsIGRldmljZXMKICAqIHRo
 YXQgYXJlIG1hcmtlZCBoaWRkZW4gYnkgdGhlIGZpcm13YXJlIHNob3VsZCBiZSBleHBvc2VkIGFu
 eXdheXMuCisgKiAgICAwIDogaGlkZSAoZGVmYXVsdCkKKyAqICAgIDEgOiBleHBvc2U7IGV4cG9y
 dCBkaXNrcyBhcyBwYXNzdGhyb3VnaCBkZXZpY2VzCisgKiAgICAyIDogZXhwb3NlOyBleHBvcnQg
 ZGlza3MgYXMgZGlyZWN0LWFjY2VzcyBkZXZpY2VzCiAgKi8KIHN0YXRpYyB1bnNpZ25lZCBpbnQg
 Y2lzc19leHBvc2VfaGlkZGVuX3BoeXNpY2FsID0gMDsKIFRVTkFCTEVfSU5UKCJody5jaXNzLmV4
 cG9zZV9oaWRkZW5fcGh5c2ljYWwiLCAmY2lzc19leHBvc2VfaGlkZGVuX3BoeXNpY2FsKTsKQEAg
 LTI3MCw2ICsyNzMsMTMgQEAKIHN0YXRpYyBpbnQgY2lzc19mb3JjZV9pbnRlcnJ1cHQgPSAwOwog
 VFVOQUJMRV9JTlQoImh3LmNpc3MuZm9yY2VfaW50ZXJydXB0IiwgJmNpc3NfZm9yY2VfaW50ZXJy
 dXB0KTsKIAorLyoKKyAqIFRoaXMgdHVuYWJsZSBjb250cm9scyBob3cgbWFueSBsb2dpY2FsIGRy
 aXZlcyB0aGlzIGRyaXZlciBjYW4gaGFuZGxlLgorICogSXQgZGVmYXVsdHMgdG8gQ0lTU19NQVhf
 TE9HSUNBTC4KKyAqLworc3RhdGljIGludCBjaXNzX21heF9sb2dpY2FsID0gQ0lTU19NQVhfTE9H
 SUNBTDsKK1RVTkFCTEVfSU5UKCJody5jaXNzLm1heF9sb2dpY2FsIiwgJmNpc3NfbWF4X2xvZ2lj
 YWwpOworCiAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
 KioqKioqKioqKioqKioqKioqKioqKioqCiAgKiBDSVNTIGFkYXB0ZXJzIGFtYXppbmdseSBkb24n
 dCBoYXZlIGEgZGVmaW5lZCBwcm9ncmFtbWluZyBpbnRlcmZhY2UKICAqIHZhbHVlLiAgKE9uZSBj
 b3VsZCBzYXkgc29tZSB2ZXJ5IGRlc3BhaXJpbmcgdGhpbmdzIGFib3V0IFBDSSBhbmQKQEAgLTEz
 MTEsNyArMTMyMSw3IEBACiAJYnJlYWs7CiAgICAgY2FzZSBDSVNTX0NNRF9TVEFUVVNfREFUQV9P
 VkVSUlVOOgogCWNpc3NfcHJpbnRmKHNjLCAiV0FSTklORzogbW9yZSB1bml0cyB0aGFuIGRyaXZl
 ciBsaW1pdCAoJWQpXG4iLAotCQkgICAgQ0lTU19NQVhfTE9HSUNBTCk7CisJCSAgICBjaXNzX21h
 eF9sb2dpY2FsKTsKIAlicmVhazsKICAgICBkZWZhdWx0OgogCWNpc3NfcHJpbnRmKHNjLCAiZXJy
 b3IgZGV0ZWN0aW5nIGxvZ2ljYWwgZHJpdmUgY29uZmlndXJhdGlvbiAoJXMpXG4iLApAQCAtMTM0
 NSw3ICsxMzU1LDcgQEAKICAgICBkZWJ1Z19jYWxsZWQoMSk7CiAKICAgICBjbGwgPSBjaXNzX3Jl
 cG9ydF9sdW5zKHNjLCBDSVNTX09QQ09ERV9SRVBPUlRfTE9HSUNBTF9MVU5TLAotCQkJICAgQ0lT
 U19NQVhfTE9HSUNBTCk7CisJCQkgICBjaXNzX21heF9sb2dpY2FsKTsKICAgICBpZiAoY2xsID09
 IE5VTEwpIHsKIAllcnJvciA9IEVOWElPOwogCWdvdG8gb3V0OwpAQCAtMTM1Myw5ICsxMzYzLDkg
 QEAKIAogICAgIC8qIHNhbml0eS1jaGVjayByZXBseSAqLwogICAgIG5kcml2ZXMgPSAobnRvaGwo
 Y2xsLT5saXN0X3NpemUpIC8gc2l6ZW9mKHVuaW9uIGNpc3NfZGV2aWNlX2FkZHJlc3MpKTsKLSAg
 ICBpZiAoKG5kcml2ZXMgPCAwKSB8fCAobmRyaXZlcyA+IENJU1NfTUFYX0xPR0lDQUwpKSB7Cisg
 ICAgaWYgKChuZHJpdmVzIDwgMCkgfHwgKG5kcml2ZXMgPiBjaXNzX21heF9sb2dpY2FsKSkgewog
 CWNpc3NfcHJpbnRmKHNjLCAiYWRhcHRlciBjbGFpbXMgdG8gcmVwb3J0IGFic3VyZCBudW1iZXIg
 b2YgbG9naWNhbCBkcml2ZXMgKCVkID4gJWQpXG4iLAotCQkgICAgbmRyaXZlcywgQ0lTU19NQVhf
 TE9HSUNBTCk7CisJCSAgICBuZHJpdmVzLCBjaXNzX21heF9sb2dpY2FsKTsKIAllcnJvciA9IEVO
 WElPOwogCWdvdG8gb3V0OwogICAgIH0KQEAgLTEzNzgsMTkgKzEzODgsMTkgQEAKIAogICAgIGZv
 ciAoaSA9IDA7IGkgPD0gc2MtPmNpc3NfbWF4X2xvZ2ljYWxfYnVzOyBpKyspIHsKIAlzYy0+Y2lz
 c19sb2dpY2FsW2ldID0KLQkgICAgbWFsbG9jKENJU1NfTUFYX0xPR0lDQUwgKiBzaXplb2Yoc3Ry
 dWN0IGNpc3NfbGRyaXZlKSwKKwkgICAgbWFsbG9jKGNpc3NfbWF4X2xvZ2ljYWwgKiBzaXplb2Yo
 c3RydWN0IGNpc3NfbGRyaXZlKSwKIAkJICAgQ0lTU19NQUxMT0NfQ0xBU1MsIE1fTk9XQUlUIHwg
 TV9aRVJPKTsKIAlpZiAoc2MtPmNpc3NfbG9naWNhbFtpXSA9PSBOVUxMKSB7CiAJICAgIGVycm9y
 ID0gRU5YSU87CiAJICAgIGdvdG8gb3V0OwogCX0KIAotCWZvciAoaiA9IDA7IGogPCBDSVNTX01B
 WF9MT0dJQ0FMOyBqKyspCisJZm9yIChqID0gMDsgaiA8IGNpc3NfbWF4X2xvZ2ljYWw7IGorKykK
 IAkgICAgc2MtPmNpc3NfbG9naWNhbFtpXVtqXS5jbF9zdGF0dXMgPSBDSVNTX0xEX05PTkVYSVNU
 RU5UOwogICAgIH0KIAogCi0gICAgZm9yIChpID0gMDsgaSA8IENJU1NfTUFYX0xPR0lDQUw7IGkr
 KykgeworICAgIGZvciAoaSA9IDA7IGkgPCBjaXNzX21heF9sb2dpY2FsOyBpKyspIHsKIAlpZiAo
 aSA8IG5kcml2ZXMpIHsKIAkgICAgc3RydWN0IGNpc3NfbGRyaXZlCSpsZDsKIAkgICAgaW50CQkJ
 YnVzLCB0YXJnZXQ7CkBAIC0xOTc1LDcgKzE5ODUsNyBAQAogCWJ1c19kbWFfdGFnX2Rlc3Ryb3ko
 c2MtPmNpc3NfcGFyZW50X2RtYXQpOwogICAgIGlmIChzYy0+Y2lzc19sb2dpY2FsKSB7CiAJZm9y
 IChpID0gMDsgaSA8PSBzYy0+Y2lzc19tYXhfbG9naWNhbF9idXM7IGkrKykgewotCSAgICBmb3Ig
 KGogPSAwOyBqIDwgQ0lTU19NQVhfTE9HSUNBTDsgaisrKSB7CisJICAgIGZvciAoaiA9IDA7IGog
 PCBjaXNzX21heF9sb2dpY2FsOyBqKyspIHsKIAkJaWYgKHNjLT5jaXNzX2xvZ2ljYWxbaV1bal0u
 Y2xfbGRyaXZlKQogCQkgICAgZnJlZShzYy0+Y2lzc19sb2dpY2FsW2ldW2pdLmNsX2xkcml2ZSwg
 Q0lTU19NQUxMT0NfQ0xBU1MpOwogCQlpZiAoc2MtPmNpc3NfbG9naWNhbFtpXVtqXS5jbF9sc3Rh
 dHVzKQpAQCAtMjk1OCw5ICsyOTY4LDkgQEAKIAljcGktPmhiYV9pbnF1aXJ5ID0gUElfVEFHX0FC
 TEU7CS8qIFhYWCBpcyB0aGlzIGNvcnJlY3Q/ICovCiAJY3BpLT50YXJnZXRfc3BydCA9IDA7CiAJ
 Y3BpLT5oYmFfbWlzYyA9IDA7Ci0JY3BpLT5tYXhfdGFyZ2V0ID0gQ0lTU19NQVhfTE9HSUNBTDsK
 KwljcGktPm1heF90YXJnZXQgPSBjaXNzX21heF9sb2dpY2FsOwogCWNwaS0+bWF4X2x1biA9IDA7
 CQkvKiAnbG9naWNhbCBkcml2ZScgY2hhbm5lbCBvbmx5ICovCi0JY3BpLT5pbml0aWF0b3JfaWQg
 PSBDSVNTX01BWF9MT0dJQ0FMOworCWNwaS0+aW5pdGlhdG9yX2lkID0gY2lzc19tYXhfbG9naWNh
 bDsKIAlzdHJuY3B5KGNwaS0+c2ltX3ZpZCwgIkZyZWVCU0QiLCBTSU1fSURMRU4pOwogICAgICAg
 ICBzdHJuY3B5KGNwaS0+aGJhX3ZpZCwgIm1zbWl0aEBmcmVlYnNkLm9yZyIsIEhCQV9JRExFTik7
 CiAgICAgICAgIHN0cm5jcHkoY3BpLT5kZXZfbmFtZSwgY2FtX3NpbV9uYW1lKHNpbSksIERFVl9J
 RExFTik7CkBAIC0zMzE2LDcgKzMzMjYsOCBAQAogCSAqIGF0dGFjaGVkIGJ5IHRoZSBQQVNTIGRy
 aXZlci4KIAkgKi8KIAlpZiAoQ0lTU19JU19QSFlTSUNBTChidXMpKSB7Ci0JICAgIGlmIChTSURf
 VFlQRShpbnEpID09IFRfRElSRUNUKQorCSAgICBpZiAoKFNJRF9UWVBFKGlucSkgPT0gVF9ESVJF
 Q1QpICYmCisJICAgICAgIChjaXNzX2V4cG9zZV9oaWRkZW5fcGh5c2ljYWwgPD0gMSkpCiAJCWlu
 cS0+ZGV2aWNlID0gKGlucS0+ZGV2aWNlICYgMHhlMCkgfCBUX05PREVWSUNFOwogCSAgICByZXR1
 cm47CiAJfQpAQCAtMzg3MSw3ICszODgyLDcgQEAKICAgICAgKiBkcml2ZSBhZGRyZXNzLgogICAg
 ICAqLwogICAgIGNsbCA9IGNpc3NfcmVwb3J0X2x1bnMoc2MsIENJU1NfT1BDT0RFX1JFUE9SVF9M
 T0dJQ0FMX0xVTlMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBDSVNTX01BWF9MT0dJQ0FM
 KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIGNpc3NfbWF4X2xvZ2ljYWwpOwogICAgIGlm
 IChjbGwgPT0gTlVMTCkKICAgICAgICAgcmV0dXJuOwogCkBAIC0zODgyLDcgKzM4OTMsNyBAQAog
 ICAgICAqIGZpcm13YXJlLgogICAgICAqLwogICAgIGZvciAoaSA9IDA7IGkgPCBzYy0+Y2lzc19t
 YXhfbG9naWNhbF9idXM7IGkrKykgewotCWZvciAoaiA9IDA7IGogPCBDSVNTX01BWF9MT0dJQ0FM
 OyBqKyspIHsKKwlmb3IgKGogPSAwOyBqIDwgY2lzc19tYXhfbG9naWNhbDsgaisrKSB7CiAJICAg
 IGxkID0gJnNjLT5jaXNzX2xvZ2ljYWxbaV1bal07CiAKIAkgICAgaWYgKGxkLT5jbF91cGRhdGUg
 PT0gMCkKQEAgLTQyOTksNyArNDMxMCw3IEBACiAJIlwyMFwxbm90aWZ5X29rXDJjb250cm9sX29w
 ZW5cM2Fib3J0aW5nXDRydW5uaW5nXDIxZmFrZV9zeW5jaFwyMmJtaWNfYWJvcnRcbiIpOwogCiAg
 ICAgZm9yIChpID0gMDsgaSA8IHNjLT5jaXNzX21heF9sb2dpY2FsX2J1czsgaSsrKSB7Ci0JZm9y
 IChqID0gMDsgaiA8IENJU1NfTUFYX0xPR0lDQUw7IGorKykgeworCWZvciAoaiA9IDA7IGogPCBj
 aXNzX21heF9sb2dpY2FsOyBqKyspIHsKIAkgICAgY2lzc19wcmludGYoc2MsICJMT0dJQ0FMIERS
 SVZFICVkOiAgIiwgaSk7CiAJICAgIGNpc3NfcHJpbnRfbGRyaXZlKHNjLCAmc2MtPmNpc3NfbG9n
 aWNhbFtpXVtqXSk7CiAJfQpJbmRleDogc2hhcmUvbWFuL21hbjQvY2lzcy40Cj09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
 LS0tIHNoYXJlL21hbi9tYW40L2Npc3MuNAkocmV2aXNpb24gMjQ0MzYxKQorKysgc2hhcmUvbWFu
 L21hbjQvY2lzcy40CSh3b3JraW5nIGNvcHkpCkBAIC03NywxMSArNzcsMTUgQEAKIG1hcmtlZCBh
 cyBiZWluZyBtYXNrZWQuCiBNYXNrZWQgZGV2aWNlcyBjYW4gYmUgZXhwb3NlZCBieSBzZXR0aW5n
 IHRoZQogLlZhIGh3LmNpc3MuZXhwb3NlX2hpZGRlbl9waHlzaWNhbAotdHVuYWJsZSB0byBub24t
 emVybyBhdCBib290IHRpbWUuCit0dW5hYmxlIHRvIDEgYXQgYm9vdCB0aW1lLgogRGlyZWN0IEFj
 Y2VzcyBkZXZpY2VzIChzdWNoIGFzIGRpc2sKIGRyaXZlcykgYXJlIG9ubHkgZXhwb3NlZCBhcwog
 LlhyIHBhc3MgNAotZGV2aWNlcy4KK2RldmljZXMuIFRvIGV4cG9zZSB0aGVtIGFzCisuWHIgZGEg
 NAorZGV2aWNlcyBpbnN0ZWFkLCBzZXQKKy5WYSBody5jaXNzLmV4cG9zZV9oaWRkZW5fcGh5c2lj
 YWwKK3RvIDIgYXQgYm9vdCB0aW1lLgogSG90LWluc2VydGlvbiBhbmQgcmVtb3ZhbCBvZiBkZXZp
 Y2VzIGlzIHN1cHBvcnRlZCBidXQgYSBidXMKIHJlc2NhbiBtaWdodCBiZSBuZWNlc3NhcnkuCiAu
 UHAKQEAgLTkwLDYgKzk0LDEzIEBACiBtaWdodCBiZSBzb2x2ZWQgYnkgdXBkYXRpbmcgdGhlIGZp
 cm13YXJlIGFuZC9vciBzZXR0aW5nIHRoZQogLlZhIGh3LmNpc3Mubm9wX21lc3NhZ2VfaGVhcnRi
 ZWF0CiB0dW5hYmxlIHRvIG5vbi16ZXJvIGF0IGJvb3QgdGltZS4KKy5QcAorQnkgZGVmYXVsdCB0
 aGUgZHJpdmVyIHJlc3RyaWN0cyB0aGUgbWF4aW11bSBudW1iZXIgb2YgbG9naWNhbCBkcml2ZXMg
 dG8gMTUgaW4KK29yZGVyIHRvIGxpbWl0IHRoZSBhbW91bnQgb2YgbWVtb3J5IHJlcXVpcmVkIGJ5
 IHRoZSBkcml2ZXIuIFRoaXMgbGltaXQgY2FuCitiZSBpbmNyZWFzZWQgKGFzIGxvbmcgYXMgdGhl
 IGNvbXB1dGVyIGhhcyBlbm91Z2ggbWVtb3J5IGJlbG93IDQgR2lCIGZvciBETUEKK0kvTykgYnkg
 c2V0dGluZyB0aGUKKy5WYSBody5jaXNzLm1heF9sb2dpY2FsCit0dW5hYmxlIHRvIHRoZSBuZXcg
 bGltaXQgYXQgYm9vdCB0aW1lLgogLlNoIEhBUkRXQVJFCiBDb250cm9sbGVycyBzdXBwb3J0ZWQg
 YnkgdGhlCiAuTm0K

 ------_=_NextPart_001_01CDDEC4.2B270089--