Buglet in r222899 (mfiutil show drives)

Andrew Boyer aboyer at averesystems.com
Fri Jul 29 19:42:08 UTC 2011


The error variable is returned uninitialized if no error occurs.  I noticed because 'mfiutil -de show drives' started returning 1 for no apparent reason when I synced up to stable/8.

I looked through the rest of mfiutil and didn't see any more cases like this one.

-Andrew

Index: usr.sbin/mfiutil/mfi_show.c
===================================================================
--- usr.sbin/mfiutil/mfi_show.c	(revision 224494)
+++ usr.sbin/mfiutil/mfi_show.c	(working copy)
@@ -470,7 +470,7 @@
 	struct mfi_pd_list *list;
 	struct mfi_pd_info info;
 	u_int i, len, state_len;
-	int error, fd;
+	int error = 0, fd;
 
 	if (ac != 1) {
 		warnx("show drives: extra arguments");

--------------------------------------------------
Andrew Boyer	aboyer at averesystems.com






More information about the freebsd-scsi mailing list