patches for CAM SCSI probing, etc.

Matthew Jacob mj at feral.com
Wed May 26 18:21:11 UTC 2010


Okay, I see your point.

I would assert that for SCSI there should only be one probe active at 
any time for any given nexus *or* I should adopt your approach and 
restart the state machine if additional commands show up.

It's also true that scans ought to be limited from user space. There's 
nothing to stop one from running 1000 camcontrol rescans from user 
space, and that effectively hangs the system as it's spending all of its 
time running stuff for them, so I might put a bit of serialization in here.

Thoughts?

> Matthew Jacob wrote:
>    
>> Part of the reason I went the way you had done for ATA is to try and
>> guarantee one and one only probe action at a time per nexus.
>>      
> But in ATA I am restarting probe from the begining when new request
> arrive. Look on "softc->restart".
>
>    
>>> you are slightly changing semantics of device probe. Previously, probe
>>> call means warranty that device will be probed from the beginning after
>>> the moment of request. It is very important for ATA, as probe function
>>> also initializes device, that is mandatory if probe is called as result
>>> of device reset. SCSI devices probably don't need that initialization,
>>> but what if probe was called due to inquiry change status received
>>> during probe sequence running? Are you sure you won't loose events here?
>>>        
>    



More information about the freebsd-scsi mailing list