Sense fetching [Was: cdrtools /devel ...]

[Brandon Gooch]

On Sun, Nov 14, 2010 at 9:32 AM, Alexander Motin <mav at freebsd.org> wrote:
> Brandon Gooch wrote:
>> On Sat, Nov 13, 2010 at 3:34 AM, Alexander Motin <mav at freebsd.org> wrote:
>>> Now uncommitted pass_autosence.patch and possibly cdrtools.patch.
>>
>> OK. Patched kernel and cdrtools has resulted in a working cdrecord
>> (burned an ISO successfully) and an endless stream of:
>>
>> ...
>> (pass0:ata0:0:0:0): Requesting SCSI sense data
>> (pass0:ata0:0:0:0): SCSI status error
>> (pass0:ata0:0:0:0): Requesting SCSI sense data
>> (pass0:ata0:0:0:0): SCSI status error
>> (pass0:ata0:0:0:0): Requesting SCSI sense data
>> (pass0:ata0:0:0:0): SCSI status error
>> (pass0:ata0:0:0:0): Requesting SCSI sense data
>> (pass0:ata0:0:0:0): SCSI status error
>> ...
>
> I think it can be hald probing for media insertion. Probably we should
> slightly reduce error logging verbosity. May be somehow make to not log
> errors on requests submitted from user-level via pass driver.
>
>> But most important part: It works, and it burned very quickly! The CD
>> was created, and fully functional (I booted the Fedora image and
>> completed an installation).
>
> Nice!

What are your thoughts on committing this (or something like it)?
Should I just keep a local patch set for the semi-long-term? Do you
have something else in the works?

-Brandon