MFC of "Large set of CAM improvements" breaks I/O to Adaptec 29160 SCSI controller

[Andy Farkas]

On Wed, Apr 28, 2010 at 6:12 AM, Scott Long <scottl at samsco.org> wrote:

> ACK.  It'll take a little bit to unwind the problem out of that big
> commit, and I'm consumed with finals and work at the moment.  If
> someone else doesn't fix it in the next few days, I'm going to propose
> that the entire commit be reverted.

Yes, the commit was huge and touched many parts of CAM. I tried to identify
where the problem could be, but got lost in a maze of twisty passages...

Here is the difference between 2010.02.14 and 2010.02.15:

Updating collection src-all/cvs
 Edit src/sbin/camcontrol/camcontrol.c
 Edit src/sbin/sysctl/sysctl.8
 Edit src/sbin/sysctl/sysctl.c
 Edit src/share/man/man4/vr.4
 Edit src/share/man/man9/alloc_unr.9
 Edit src/sys/cam/ata/ata_all.c
 Edit src/sys/cam/ata/ata_da.c
 Edit src/sys/cam/ata/ata_pmp.c
 Edit src/sys/cam/ata/ata_xpt.c
 Edit src/sys/cam/cam.c
 Edit src/sys/cam/cam.h
 Edit src/sys/cam/cam_ccb.h
 Edit src/sys/cam/cam_periph.c
 Edit src/sys/cam/cam_periph.h
 Edit src/sys/cam/cam_queue.h
 Edit src/sys/cam/cam_sim.c
 Edit src/sys/cam/cam_xpt.c
 Edit src/sys/cam/cam_xpt.h
 Edit src/sys/cam/cam_xpt_internal.h
 Edit src/sys/cam/cam_xpt_periph.h
 Edit src/sys/cam/cam_xpt_sim.h
 Edit src/sys/cam/scsi/scsi_all.c
 Edit src/sys/cam/scsi/scsi_cd.c
 Edit src/sys/cam/scsi/scsi_ch.c
 Edit src/sys/cam/scsi/scsi_da.c
 Edit src/sys/cam/scsi/scsi_low.c
 Edit src/sys/cam/scsi/scsi_pass.c
 Edit src/sys/cam/scsi/scsi_xpt.c
 Edit src/sys/dev/ahci/ahci.c
 Edit src/sys/dev/ahci/ahci.h
 Edit src/sys/dev/asr/asr.c
 Edit src/sys/dev/ata/ata-all.c
 Edit src/sys/dev/ata/ata-all.h
 Edit src/sys/dev/ata/ata-pci.c
 Edit src/sys/dev/ata/ata-pci.h
 Edit src/sys/dev/ata/ata_if.m
 Edit src/sys/dev/ata/atapi-cam.c
 Edit src/sys/dev/ata/chipsets/ata-marvell.c
 Edit src/sys/dev/ata/chipsets/ata-netcell.c
 Edit src/sys/dev/ata/chipsets/ata-siliconimage.c
 Edit src/sys/dev/ciss/ciss.c
 Edit src/sys/dev/hptiop/hptiop.c
 Edit src/sys/dev/hptrr/hptrr_osm_bsd.c
 Edit src/sys/dev/hptrr/os_bsd.h
 Edit src/sys/dev/mly/mly.c
 Edit src/sys/dev/mpt/mpt_cam.c
 Edit src/sys/dev/mpt/mpt_cam.h
 Edit src/sys/dev/mpt/mpt_raid.c
 Edit src/sys/dev/ppbus/vpo.c
 Edit src/sys/dev/siis/siis.c
 Edit src/sys/dev/siis/siis.h
 Edit src/sys/dev/sound/pcm/dsp.c
 Edit src/sys/dev/sound/pcm/mixer.c
 Edit src/sys/dev/trm/trm.c
 Edit src/sys/dev/twa/tw_osl_cam.c
 Edit src/sys/dev/usb/storage/umass.c
 Edit src/sys/dev/wpi/if_wpi.c
 Edit src/sys/fs/nfsclient/nfs_clvfsops.c
 Edit src/sys/fs/nfsclient/nfs_clvnops.c
 Edit src/sys/fs/nfsclient/nfsmount.h
 Edit src/sys/fs/nfsclient/nfsnode.h
 Edit src/sys/sys/ata.h
Finished successfully

-andyf