cd(4) M_WAITOK allocations with periph lock held
Jaakko Heinonen
jh at FreeBSD.org
Wed Dec 2 13:59:23 UTC 2009
Hi,
On 2009-12-01, Scott Long wrote:
> How about the attached match instead. It refactors the code so that
> unlocks aren't needed.
Looks OK to me. Some nits below.
> bailout:
> + xpt_release_ccb(ccb);
> + cam_periph_unlock(periph);
> +
The file seems to have an empty line after labels in other places. Maybe
put one here too.
> bailout:
>
> + xpt_release_ccb(ccb);
> + cam_periph_unlock(periph);
You can remove the now unused "bailout:" label from cdsendkey().
Do you want to commit it?
Thanks.
--
Jaakko
More information about the freebsd-scsi
mailing list