cd(4) M_WAITOK allocations with periph lock held

[Kostik Belousov]

On Tue, Dec 01, 2009 at 08:05:25PM +0200, Jaakko Heinonen wrote:
> 
> Hi,
> 
> There are some M_WAITOK malloc invocations with periph lock held in
> cd(4). Below is a link to a patch which drops the periph lock while
> doing those allocations. Comments/review?
> 
> ---
> 
> Drop periph lock while allocating memory with M_WAITOK flag in
> cdreportkey(), cdsendkey() and cdreaddvdstructure().
> 
> PR:		kern/130735
> Tested by:	Eygene Ryabinkin
> 
> The patch against head:
> 
> http://people.freebsd.org/~jh/patches/scsi_cd-M_WAITOK-fixes.diff

Would be useful for non-CAM people to put a little education into the
commit log, describing why it is safe to drop the lock.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-scsi/attachments/20091201/1bef9d64/attachment.pgp