RELENG_6 patch for MPT

Sean Bruno sbruno at miralink.com
Wed Aug 20 22:14:36 UTC 2008


Hmmm...RELENG_6 looks like it has a locking issue at this time.

The patch below removes the panic due to dead lock, but I'm not sure
how safe it is.


Index: /trunk/src/ankeny/src/FreeBSD_RELENG6/sys/dev/mpt/mpt_user.c
===================================================================
--- /trunk/src/ankeny/src/FreeBSD_RELENG6/sys/dev/mpt/mpt_user.c (revision 5657)
+++ /trunk/src/ankeny/src/FreeBSD_RELENG6/sys/dev/mpt/mpt_user.c (revision 5761)
@@ -106,15 +106,13 @@
 mpt_user_attach(struct mpt_softc *mpt)
 {
 	mpt_handler_t handler;
 	int error, unit;
 
-	MPT_LOCK(mpt);
 	handler.reply_handler = mpt_user_reply_handler;
 	error = mpt_register_handler(mpt, MPT_HANDLER_REPLY, handler,
 				     &user_handler_id);
-	MPT_UNLOCK(mpt);
 	if (error != 0) {
 		mpt_prt(mpt, "Unable to register user handler!\n");
 		return (error);
 	}
 	unit = device_get_unit(mpt->dev);

-- 
Sean Bruno
MiraLink Corporation
6015 NE 80th Ave, Ste 100
Portland, OR 97218
Phone 503-621-5143
Fax 503-621-5199
MSN: sbruno at miralink.com
Google:  seanwbruno at gmail.com
Yahoo:  sean_bruno at yahoo.com



More information about the freebsd-scsi mailing list