Retirement of CAM_QUIRK_NOSERIAL

[Ulrich Spoerlein]

On Sun, 16.09.2007 at 11:48:00 -0600, Scott Long wrote:
> Ulrich Spoerlein wrote:
> > While this patch is working fine with my USB/FW HDD enclosure, it breaks
> > my MP3 USB stick
> > kernel: umass0: <Samsung YP-U2, class 0/0, rev 2.00/10.01, addr 8> on uhub5
> > kernel: umass0: BBB reset failed, IOERROR
> > kernel: umass0: BBB bulk-in clear stall failed, IOERROR
> > kernel: umass0: BBB bulk-out clear stall failed, IOERROR
> 
> Is this a regression of something that works without the patch, or is
> it something that has never worked?  What happens if you use the
> NO_INQUIRY_EVPD quirk instead?

This is a regression, I will test the EVPD quirk tomorrow ...

> > It's funny, though. If I quirk this Plextor DVD to NO_INQUIRY, it will 
> > attach
> > via da(4) (sic!) and suddenly all kinds of DVD media start working!
> > umass0: <PLEXTOR DVDR   PX-755A, class 0/0, rev 2.00/4.35, addr 8> on uhub5
> > da0 at umass-sim0 bus 0 target 0 lun 0
> > da0: <  > Removable Direct Access SCSI-2 device da0: 40.000MB/s transfers
> > da0: 3001MB (1536688 2048 byte sectors: 255H 63S/T 95C)
> 
> I'm honestly having a really hard time believing that a device could
> claim to support "SCSI" but not support a basic INQUIRY command.  That's
> the one command that is absolutely essential to any SCSI device.  What
> if you try the NO_INQUIRY_EVPD or FORCE_SHORT_INQUIRY quirks?

Sorry for not making myself clear. The device has always attached via
cd(4) and worked for CD and self-burned DVD, but not retail DVD. If I
quirk it, it will attach via da(4) *instead* of cd(4), and retail DVD
magically start working.

If I use atausb(4)/acd(4) some of the retail DVDs work and if I extract
the drive from the case and attach it via atapi(4)/acd(4) everything is
working fine, too. It is only cd(4) that is not grokking retail DVDs, be
it via umass(4) or sbp(4).

I doubt your patch is intended to change the runtime behaviour of cd(4)
with respect to handling inserted media, right?

I'll give those quirks you mentioned a try, but that will only fix the
umass(4)/cd(4) issue, not the sbp(4)/cd(4) one.

Cheers,
Ulrich Spoerlein
-- 
It is better to remain silent and be thought a fool,
than to speak, and remove all doubt.