CAM_NEW_TRAN- kernel changes ready for review
Scott Long
scottl at samsco.org
Sun Oct 29 05:30:46 UTC 2006
Matthew Jacob wrote:
> This has been updated after I found I'd forgotten to fill in a couple
> of items (*cough*).
>
1) I thought that you were just going to push forward and make NEW_TRAN
be the de-facto. Why bother keeping the #ifdefs? If I misunderstood,
I apologize.
2) Does the protocol_version field in the cts and cpi refer to the SCSI
protocol (i.e. SCSI-1/2/3, etc)? If so, isn't that more of a per-device
quality, not a per-sim quality? Hard-coding it in the SIM for all
devices would then seem wrong, shouldn't CAM get it out of the INQ data?
3) For atapi-cam, I think that the cts->protocol should still be
PROTO_SCSI, not PROTO_ATA. Having cpi->transport by XPORT_SPI also
seems wrong, as IDE is fairly different from SPI, and I'd like at some
point to have a real IDE/SATA transport that understands the
differences. For that matter, it might also be useful to differentiate
between PROTO_SCSI and say PROTO_RBC or PROTO_ATAPI or PROTO_MMC. Might
make dealing with USB and firewire easier than the quirky mess that is
there now.
Otherwise, looks pretty good. If you want to push forward and commit, I
can help clean up any goofs or missed drivers.
Scott
More information about the freebsd-scsi
mailing list