LUN probing problem with 6.0-BETA4 and seagate drive

[Andrew Heybey]

I just upgraded a box from 5.3 to 6.0-BETA4.

I have this drive on the system:

da5 at ahc1 bus 0 target 0 lun 0
da5: <SEAGATE SX336704LC BC0A> Fixed Direct Access SCSI-3 device 
da5: 40.000MB/s transfers (20.000MHz, offset 63, 16bit)
da5: 34732MB (71132960 512 byte sectors: 255H 63S/T 4427C)

I think that the "SX" means it has EMC firmware (not sure of the drives
history, it is an ebay purchase).

It is attached to this HBA:

ahc1: <Adaptec aic7899 Ultra160 SCSI adapter> port 0x6000-0x60ff mem 0xfc001000-0xfc001fff irq 17 at device 4.1 on pci1

With 5.3 it worked fine.  With 6.0-BETA4, I get 200+ iterations of this message at boot time:

Sep 13 14:26:45 spaten kernel: SEQADDR == 0x16c
Sep 13 14:26:45 spaten kernel: ahc1:A:0: Message reject for 80 -- ignored
Sep 13 14:26:45 spaten kernel: (probe0:ahc1:0:0:56): Unexpected busfree in Message-in phase
Sep 13 14:26:45 spaten kernel: SEQADDR == 0x16c
Sep 13 14:26:45 spaten kernel: ahc1:A:0: Message reject for 80 -- ignored
Sep 13 14:26:45 spaten kernel: (probe0:ahc1:0:0:57): Unexpected busfree in Message-in phase

I worked around the problem by applying the following patch to sys/cam/cam_xpt.c:

Index: cam_xpt.c
===================================================================
RCS file: /usr/local/repos/fbsdcvs/src/sys/cam/cam_xpt.c,v
retrieving revision 1.155
diff -u -u -r1.155 cam_xpt.c
--- cam_xpt.c   1 Jul 2005 15:21:29 -0000       1.155
+++ cam_xpt.c   15 Sep 2005 12:47:06 -0000
@@ -477,6 +477,15 @@
        },
        {
                /*
+                * This Seagate drive with EMC firmware causes
+                * "Unexpected busfree" and "message reject"
+                * messages at boot time when LUNs are probed.
+                */
+               { T_DIRECT, SIP_MEDIA_FIXED, "SEAGATE", "SX336704*", "*" },
+               CAM_QUIRK_NOLUNS, /*mintags*/0, /*maxtags*/0
+       },
+       {
+               /*
                 * The Hitachi CJ series with J8A8 firmware apparantly has
                 * problems with tagged commands.
                 * PR: 23536

Is this the correct thing to do, or is there a bug in the ahc driver?  I am
curious why I get "Unexpected busfree" messages with 6.0-BETA4 and not with
5.3.  If the quirk is the right thing to do, it should probably be "SX*"...

andrew