Fwd: commit approval?

[Kenneth D. Merry]

On Sat, Feb 28, 2004 at 02:02:46 +0000, Colin Percival wrote:
>   I don't think anyone approved this patch -- is it ok with you guys?

Approved.

Sorry for the delay in responding.

> Colin Percival
> 
> >> Compare the *number* of patterns to zero, not the *pointer* to the
> >> patterns.  (These lines are correct the other two times they appear.)
> >>
> >> Reported by:  "Ted Unangst" <tedu at coverity.com>
> >>
> >> Index: src/sys/cam/cam_xpt.c
> >> ===================================================================
> >> RCS file: /home/ncvs/src/sys/cam/cam_xpt.c,v
> >> retrieving revision 1.135
> >> diff -u -r1.135 cam_xpt.c
> >> --- src/sys/cam/cam_xpt.c     9 Nov 2003 02:22:33 -0000       1.135
> >> +++ src/sys/cam/cam_xpt.c     20 Feb 2004 15:34:32 -0000
> >> @@ -1882,7 +1882,7 @@
> >>       * If there are no match entries, then this device matches no
> >>       * matter what.
> >>       */
> >> -     if ((patterns == NULL) || (patterns == 0))
> >> +     if ((patterns == NULL) || (num_patterns == 0))
> >>               return(DM_RET_DESCEND | DM_RET_COPY);
> >>
> >>       for (i = 0; i < num_patterns; i++) {
> 

Ken
-- 
Kenneth Merry
ken at kdm.org