[Gitlab] Current Status of the port

[Steve Wills]

On Mon, Aug 03, 2015 at 10:29:15AM +0200, Torsten Zuehlsdorff wrote:
> Hello,
> 
> >> # cd /usr/ports/devel/rubygem-gitlab_git-rails41
> >> # portlint -AC
> >> FATAL: Makefile: the last line of a slave port's Makefile has to be
> >> .include "${MASTERDIR}/Makefile"
> >> FATAL: Makefile: extra item "MASTERDIR" placed in the PORTNAME section.
> >> FATAL: Makefile: extra item "PKGNAMESUFFIX" placed in the LICENSE section.
> >> WARN: Consider to set DEVELOPER=yes in /etc/make.conf
> >> 3 fatal errors and 1 warning found.
> >
> > portlint doesn't really fully grok slave ports, unless I'm mistaken, so use
> > your judgement here, but the include does need to be last.
> 
> Okay, will fix.
> 
> >> When including the Master-Makefile in the last line, the PKGNAMESUFFIX
> >> for example is not used.
> >
> > Change the master port to use ?= instead of = for the things you want to override.

That's no problem.

> This works, but increases the number of changed ports ;)
> 
> Also it just remove one FATAL error. This other 2 persists. Is this 
> enough or should i do further research?

In slave ports only, it's OK IMHO to ignore the issues from portlint about
ordering.

Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 603 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ruby/attachments/20150803/ab41fa1c/attachment.bin>