[Bug 235185] www/fcgiwrap: environment should be cleaned in /usr/local/etc/rc.d/fcgiwrap

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Jan 26 07:05:10 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235185

--- Comment #30 from vas at mpeks.tomsk.su ---
(In reply to Rodney W. Grimes from comment #19)
> If you are calling this exporting of the environment a feature of fcgiwrap then us revoking the environment with env -i would be removing an authors inteded feature.

We are already doing that, albeit in an inconsistent manner: we clean the
environment in /usr/sbin/service and not clean when running rc.d scripts
directly). Now that I think of it, I see the major problem being this
inconsistency.

And guys, before you start coding, please remember that login.conf and other
environment variable assignments probably should go _after_ the initial
environment sanitation. So first you cut off whatever is inherited from the
invoker's environment (like it is done in /usr/sbin/service) and then you
assign the necessary variables in the rc.d script already.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-rc mailing list