Feeback on patch to add ZFS support to mdconfig rc.d scripts

[Steven Hartland]

Attached is a patch which adds ZFS support to the
mdconfig rc.d scritps along with some other little
fixes while I was there.

Our use case for this here is to create a ZFS pool
on a swap backed node for temporary data which supports
all the cool features of ZFS, for us thats compression.

Possible enhancements, suggested by pjd in IRC include
default flags such as:-o cachefile=none

Current summary:-
=======
Add ZFS pool creation support to mdconfig rc.d script

Fix failure error redirection in mount check

Fix invalid configuration detection enabling -t vnode
to be skipped if -f <file> is specified as supported
by mdconfig.

Fix fsck not working if mount point is not present in fstab.

TODO: update rc.conf man page
=======

I've tested on a number of configs including:-
mdconfig_md0="-t swap -s 12g"
mdconfig_md0_zfs_pool="tmpfs"
mdconfig_md0_zfs_flags="-m /mnt -o cachefile=none -O compression=on -O atime=off -O exec=off -O primarycache=none -O 
sync=disabled"

mdconfig_md1="-f /data/test.vnode"
mdconfig_md1_zfs_pool="vnodefs"
mdconfig_md1_zfs_flags="-m /root/vnode -o cachefile=none"

mdconfig_md2="-f /data/test2.vnode"

mdconfig_md3="-s 12g" # Should error, didn't before.

What do people think?

    Regards
    steve 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mdconfig-zfs.patch
Type: application/octet-stream
Size: 6028 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20130608/9d66c021/attachment.obj>