Making use of set_rcvar.

[Chris Rees]

On 13 Jan 2012 17:14, "Pawel Jakub Dawidek" <pjd at freebsd.org> wrote:
>
> On Fri, Jan 13, 2012 at 04:41:32PM +0000, Chris Rees wrote:
> > On 13 Jan 2012 14:12, "Pawel Jakub Dawidek" <pjd at freebsd.org> wrote:
> > > Please don't. Touching so many rc.d files is PITA during mergemaster.
> > > If we want to do that, let's do that once. The current consensus as I
> > > see it, is that you are the only one wanting to hardcode names and there
> > > are many in favour of using variables.
> > >
> >
> > Well.... hardcoding IS faster.
>
> Can you prove it with ministat(1)? What difference are we talking about?
>

I sense I'm about to get ripped a new one...

Obviously dereferencing a variable has a cost.  Normally, no big deal,
but I'm happy to research it later.

These scripts are run through a huge number of times at various
stages, and any slowdown is detrimental.

Also, I tend to agree with Doug on the <<search and replace>> issue.
If we really want to reuse code like that then we need to start using
m4 or something (I'm only being half facetious here).

Code reuse is great, but that's not really the case here.

Chris