status cleanup
Hiroki Sato
hrs at FreeBSD.org
Tue Mar 29 03:24:38 UTC 2011
Wesley Shields <wxs at freebsd.org> wrote
in <20110329024441.GA24720 at atarininja.org>:
wx> On Fri, Mar 18, 2011 at 09:31:55PM -0400, Wesley Shields wrote:
wx> > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote:
wx> > > A co-worker noticed that the pf rc script has 'status' listed twice when
wx> > > run without any arguments. The attached patch fixes that and two other
wx> > > cases where this also happens. I've only tested the pf changes. I'd
wx> > > appreciate a review of this and maybe a commit? I can file a PR if it
wx> > > would make people feel better.
wx> > >
wx> > > I'm not subscribed to this list so I would appreciate being CC'ed on any
wx> > > replies.
wx> > >
wx> > > -- WXS
wx> >
wx> > This time with the patch attached, or you can get it at:
wx> >
wx> > http://people.freebsd.org/~wxs/rc-status-cleanup.diff
wx> > -extra_commands="status prefer_ipv6 prefer_ipv4"
wx> > +extra_commands="prefer_ipv6 prefer_ipv4"
For the ip6addrctl script removing "status" is wrong. This keyword
is automatically added only when ${name}_program is defined and the
ip6addrctl does not define it.
The other two changes look good to me. If there is no objection in a
day or two, I will commit them. Thank you for your report.
-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20110329/c8c94f37/attachment.pgp
More information about the freebsd-rc
mailing list