[RFC] script for binding ARP <-> IP pairs

[Adrian Penisoara]

Hi,

On Mon, Aug 10, 2009 at 7:34 AM, Doug Barton <dougb at freebsd.org> wrote:

> On Sun, 9 Aug 2009, Xin LI wrote:
>
>  Hi, Doug,
>>
>> Doug Barton wrote:
>>
>>> Xin LI wrote:
>>>
>>>  Thanks for your comments, I have put together the revised patch, along
>>>> with rc.conf.5 and defaults/rc.conf changes.
>>>>
>>>
>>> Glad to help. This looks fine except that you need an entry for
>>> static_arp_enable in defaults rc.conf and rc.conf.5.
>>>
>>
>> This script does not require the enable knob.  If the static_arp_pairs
>> is not empty then the script would add the entries, otherwise it will
>> not do that.  Do you think we need an "enable" knob for it?  I can add
>> it but I don't feel strongly for the idea, since it would make a
>> redundant entry to represent the same semantic.
>>
>
> I missed the fact that you're not using rcvar. I'm sort of ambivalent about
> that, as I prefer things to be


I guess you could compare this to the cloned_interfaces rcvar...


> consistent, but I'm not actively opposed to it. If no one else has an
> objection go ahead and send it to -net.
>

Just a bit of QC/improvement:

Index: etc/rc.d/static_arp
===================================================================
-               echo -n 'Binding static ARP pair:'
+               echo -n 'Binding static ARP pair(s):'

-                       arp_args=`echo ${arp_args} | sed -e
s,..:..:..:..:..:..,,g`
+                       arp_args=`echo ${arp_args} | awk '{ print $1 }'`


Index: share/man/man5/rc.conf.5
===================================================================
-Set to the list of static ARP paris that are to be added at system
+Set to the list of static ARP pairs that are to be added at system


Regards,
Adrian Penisoara
EnterpriseBSD