multiple instances of ppp

Maksim Yevmenkin maksim.yevmenkin at gmail.com
Sun Oct 7 09:13:36 PDT 2007


Mike,

On 10/7/07, Mike Makonnen <mtm at freebsd.org> wrote:
> On Sat, Oct 06, 2007 at 03:49:57PM -0700, Maksim Yevmenkin wrote:
> >
> > thanks for your comments. what do you think about something like
> >
> > # PROVIDE: ppp
> > # REQUIRE: netif isdnd
> > # KEYWORD: nojail
> >
> > . /etc/rc.subr
> >
> > name="ppp"
> > rcvar=`set_rcvar`
> > command="/usr/sbin/${name}"
> > start_cmd="ppp_start"
> > start_postcmd="ppp_poststart"
> >
> > ppp_start_profile()
> > {
> >       local _ppp_profile, _ppp_mode, _ppp_nat
>
> You should lose the commas. Local variable declarations are space-separated.
>
> Other than that, looks good.

thanks! i have made a patch and submitted it to re@ for approval.

thanks,
max


More information about the freebsd-rc mailing list