[Bug 252602] www/py-notebook: Python kernel does not work since tornado websockets use Future

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252602

            Bug ID: 252602
           Summary: www/py-notebook: Python kernel does not work since
                    tornado websockets use Future
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: python at FreeBSD.org
          Reporter: monwarez at mailoo.org
          Assignee: python at FreeBSD.org
             Flags: maintainer-feedback?(python at FreeBSD.org)

Since tornado websockets use python Future, the python3 kernel crash at file

/usr/local/lib/python3.7/site-packages/notebook/services/kernels/handlers.py

at the line 207

https://github.com/jupyter/notebook/blob/57db70979b677b0c47cbecfbfbc3ba5b359bc0b3/notebook/services/kernels/handlers.py#L207


if self.ws_connection is None or self.ws_connection.is_closing():

Here since self.ws_connection is a Future it does not have the member:
is_closing

A fix would be to wait for the Future result (with or without a timeout) :

websocket = self.ws_connection.result()

And then check for
websocket.is_closing()

The dirty fix would be to ignore the test on is_closing

With the dirty fix the kernel run

The github repos have over 2k issue, it is hard to find if this error was
already reported there.

-- 
You are receiving this mail because:
You are the assignee for the bug.